diff options
author | Stefan Karpinski <stefan.karpinski@gmail.com> | 2009-01-29 17:12:27 -0800 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2009-01-30 21:06:27 -0800 |
commit | 499cc56a60b5c90415c74857035579713a07fa1b (patch) | |
tree | 133588dc8341e123e6fa24ab4444acd92c6ad200 /git-cvsserver.perl | |
parent | a34a9dbbced36999496c52b43460825732d487ba (diff) | |
download | git-499cc56a60b5c90415c74857035579713a07fa1b.tar.gz |
git-cvsserver: handle CVS 'noop' command.
The CVS protocol documentation, found at
http://www.wandisco.com/techpubs/cvs-protocol.pdf
states the following about the 'noop' command:
Response expected: yes. This request is a null command
in the sense that it doesn't do anything, but merely
(as with any other requests expecting a response) sends
back any responses pertaining to pending errors, pending
Notified responses, etc.
In accordance with this, the correct way to handle the 'noop'
command, when issued by a client, is to call req_EMPTY.
The 'noop' command is called by some CVS clients, notably
TortoiseCVS, thus making it desirable for git-cvsserver to
respond to the command rather than choking on it as unknown.
Signed-off-by: Stefan Karpinski <stefan.karpinski@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-cvsserver.perl')
-rwxr-xr-x | git-cvsserver.perl | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/git-cvsserver.perl b/git-cvsserver.perl index fef7faf339..277ee4e477 100755 --- a/git-cvsserver.perl +++ b/git-cvsserver.perl @@ -76,6 +76,7 @@ my $methods = { 'history' => \&req_CATCHALL, 'watchers' => \&req_EMPTY, 'editors' => \&req_EMPTY, + 'noop' => \&req_EMPTY, 'annotate' => \&req_annotate, 'Global_option' => \&req_Globaloption, #'annotate' => \&req_CATCHALL, |