diff options
author | Pete Wyckoff <pw@padd.com> | 2013-01-26 22:11:04 -0500 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2013-01-26 22:00:38 -0800 |
commit | 4f9273d27b399c9b6e0be372e607b9a8176c0699 (patch) | |
tree | 54f453203cfb937fedf453a3fc606bb4f2bc64f6 /git-p4.py | |
parent | 50a6b54c03219ad74b9f3f839e0321be18daeaf6 (diff) | |
download | git-4f9273d27b399c9b6e0be372e607b9a8176c0699.tar.gz |
git p4: temp branch name should use / even on windows
Commit fed2369 (git-p4: Search for parent commit on branch creation,
2012-01-25) uses temporary branches to help find the parent of a
new p4 branch. The temp branches are of the form "git-p4-tmp/%d"
for some p4 change number. Mistakenly, this string was made
using os.path.join() instead of just string concatenation. On
windows, this turns into a backslash (\), which is not allowed in
git branch names.
Reported-by: Casey McGinty <casey.mcginty@gmail.com>
Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-p4.py')
-rwxr-xr-x | git-p4.py | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -2687,7 +2687,7 @@ class P4Sync(Command, P4UserMap): blob = None if len(parent) > 0: - tempBranch = os.path.join(self.tempBranchLocation, "%d" % (change)) + tempBranch = "%s/%d" % (self.tempBranchLocation, change) if self.verbose: print "Creating temporary branch: " + tempBranch self.commit(description, filesForCommit, tempBranch) |