diff options
author | Horst H. von Brand <vonbrand@inf.utfsm.cl> | 2006-06-03 13:11:48 -0400 |
---|---|---|
committer | Junio C Hamano <junkio@cox.net> | 2006-06-04 00:00:20 -0700 |
commit | e96fd30553bb57a76ad38f703a3fea5b53c45ff9 (patch) | |
tree | 85f6a45b1df4edb6ca62fe16463a0fd1bdcbef84 /git-send-email.perl | |
parent | 16a4c6ee0d9a3d07d4d0afbbc4e3467e78065eca (diff) | |
download | git-e96fd30553bb57a76ad38f703a3fea5b53c45ff9.tar.gz |
Cleanup git-send-email.perl:extract_valid_email
- Fix the regular expressions for local addresses
- Fix the fallback regexp for non-local addresses, simplify the logic
Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'git-send-email.perl')
-rwxr-xr-x | git-send-email.perl | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/git-send-email.perl b/git-send-email.perl index ed1d89b3f7..a7a7797778 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -314,18 +314,15 @@ sub extract_valid_address { my $address = shift; # check for a local address: - return $address if ($address =~ /^([\w\-]+)$/); + return $address if ($address =~ /^([\w\-.]+)$/); if ($have_email_valid) { return Email::Valid->address($address); } else { # less robust/correct than the monster regexp in Email::Valid, # but still does a 99% job, and one less dependency - my $cleaned_address; - if ($address =~ /([^\"<>\s]+@[^<>\s]+)/) { - $cleaned_address = $1; - } - return $cleaned_address; + $address =~ /([\w\-.]+@[\w\-.]+)/; + return $1; } } |