summaryrefslogtreecommitdiff
path: root/git.c
diff options
context:
space:
mode:
authorTorsten Bögershausen <tboegi@web.de>2021-04-04 19:14:14 +0200
committerJunio C Hamano <gitster@pobox.com>2021-04-05 17:30:36 -0700
commitc7d0e61016bfa1c6aec04b0d7daec2e64cfccf3e (patch)
tree8238d28125db8ed1393bf3b7e4f9df85c25750be /git.c
parent5020774aef3fc80c89fac2e04d4ed0aeac66cdf0 (diff)
downloadgit-c7d0e61016bfa1c6aec04b0d7daec2e64cfccf3e.tar.gz
macOS: precompose startup_info->prefix
The "prefix" was precomposed for macOS in commit 5c327502 (MacOS: precompose_argv_prefix(), 2021-02-03). However, this commit forgot to update "startup_info->prefix" after precomposing. Move the (possible) precomposition towards the end of setup_git_directory_gently(), so that precompose_string_if_needed() can use git_config_get_bool("core.precomposeunicode") correctly. Keep prefix, startup_info->prefix and GIT_PREFIX_ENVIRONMENT all in sync. And as a result, the prefix no longer needs to be precomposed in git.c Reported-by: Dmitry Torilov <d.torilov@gmail.com> Helped-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Torsten Bögershausen <tboegi@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git.c')
-rw-r--r--git.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/git.c b/git.c
index 16a485fbe7..3d7eabef97 100644
--- a/git.c
+++ b/git.c
@@ -420,7 +420,7 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
int nongit_ok;
prefix = setup_git_directory_gently(&nongit_ok);
}
- prefix = precompose_argv_prefix(argc, argv, prefix);
+ precompose_argv_prefix(argc, argv, NULL);
if (use_pager == -1 && p->option & (RUN_SETUP | RUN_SETUP_GENTLY) &&
!(p->option & DELAY_PAGER_CONFIG))
use_pager = check_pager_config(p->cmd);