diff options
author | Junio C Hamano <gitster@pobox.com> | 2012-03-08 13:04:49 -0800 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2012-03-08 13:04:49 -0800 |
commit | aa145bf6f1cb45ad66250c40da3cd708956cf71e (patch) | |
tree | 2021a7f6b0dac82c0de4d327af83fafdb41a76a0 /gitweb | |
parent | 2c54517c1cdbcfe921489407c28c72d0093ab385 (diff) | |
parent | e65ceb61cd7d3fabedea8cb545f8c210b48552d4 (diff) | |
download | git-aa145bf6f1cb45ad66250c40da3cd708956cf71e.tar.gz |
Merge branch 'jn/maint-do-not-match-with-unsanitized-searchtext'
By Jakub Narebski
* jn/maint-do-not-match-with-unsanitized-searchtext:
gitweb: Fix fixed string (non-regexp) project search
Conflicts:
gitweb/gitweb.perl
Diffstat (limited to 'gitweb')
-rwxr-xr-x | gitweb/gitweb.perl | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index cd98888a93..a8b5fad266 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -3073,15 +3073,15 @@ sub filter_forks_from_projects_list { sub search_projects_list { my ($projlist, %opts) = @_; my $tagfilter = $opts{'tagfilter'}; - my $searchtext = $opts{'searchtext'}; + my $search_re = $opts{'search_regexp'}; return @$projlist - unless ($tagfilter || $searchtext); + unless ($tagfilter || $search_re); # searching projects require filling to be run before it; fill_project_list_info($projlist, $tagfilter ? 'ctags' : (), - $searchtext ? ('path', 'descr') : ()); + $search_re ? ('path', 'descr') : ()); my @projects; PROJECT: foreach my $pr (@$projlist) { @@ -3092,10 +3092,10 @@ sub search_projects_list { grep { lc($_) eq lc($tagfilter) } keys %{$pr->{'ctags'}}; } - if ($searchtext) { + if ($search_re) { next unless - $pr->{'path'} =~ /$searchtext/ || - $pr->{'descr_long'} =~ /$searchtext/; + $pr->{'path'} =~ /$search_re/ || + $pr->{'descr_long'} =~ /$search_re/; } push @projects, $pr; @@ -5484,16 +5484,16 @@ sub git_project_list_body { my $show_ctags = gitweb_check_feature('ctags'); my $tagfilter = $show_ctags ? $input_params{'ctag'} : undef; $check_forks = undef - if ($tagfilter || $searchtext); + if ($tagfilter || $search_regexp); # filtering out forks before filling info allows to do less work @projects = filter_forks_from_projects_list(\@projects) if ($check_forks); # search_projects_list pre-fills required info @projects = search_projects_list(\@projects, - 'searchtext' => $searchtext, + 'search_regexp' => $search_regexp, 'tagfilter' => $tagfilter) - if ($tagfilter || $searchtext); + if ($tagfilter || $search_regexp); # fill the rest @projects = fill_project_list_info(\@projects); |