summaryrefslogtreecommitdiff
path: root/ident.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2008-12-01 08:41:50 -0800
committerJunio C Hamano <gitster@pobox.com>2008-12-02 15:29:13 -0800
commitd404bf0288ac1a2c4276d009c0e1c88519e5a7c9 (patch)
tree72b0adf94e5aaf101ec910e5a5287c5d9c285745 /ident.c
parent46059cc63259f7a3d408fc1e52e8da9d37dc49ff (diff)
downloadgit-d404bf0288ac1a2c4276d009c0e1c88519e5a7c9.tar.gz
Add backslash to list of 'crud' characters in real name
We remove crud characters at the beginning and end of real-names so that when we see email addresses like From: "David S. Miller" <davem@davemloft.net> we drop the quotes around the name when we parse that and split it up into name and email. However, the list of crud characters was basically just a random list of common things that are found around names, and it didn't contain the backslash character that some insane scripts seem to use when quoting things. So now the kernel has a number of authors listed like Author: \"Rafael J. Wysocki\ <rjw@sisk.pl> because the author name had started out as From: \"Rafael J. Wysocki\" <rjw@sisk.pl> and the only "crud" character we noticed and removed was the final double-quote at the end. We should probably do better quote removal from names anyway, but this is the minimal obvious patch. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'ident.c')
-rw-r--r--ident.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/ident.c b/ident.c
index 09cf0c95c9..99f1c85ea5 100644
--- a/ident.c
+++ b/ident.c
@@ -121,6 +121,7 @@ static int crud(unsigned char c)
c == '<' ||
c == '>' ||
c == '"' ||
+ c == '\\' ||
c == '\'';
}