diff options
author | Junio C Hamano <gitster@pobox.com> | 2014-03-18 14:04:01 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-03-18 14:04:01 -0700 |
commit | 8aac6c97e81dee53ae7740663128b0296398d6d1 (patch) | |
tree | d6977ae7a154fe5ddb272c5e6475eb9fd4467c05 /pretty.c | |
parent | a5aca6e883639ce3a3ad07271032905edc0ac608 (diff) | |
parent | 3f419d45ef0dfc33dc301d9ae4737043c091291a (diff) | |
download | git-8aac6c97e81dee53ae7740663128b0296398d6d1.tar.gz |
Merge branch 'jk/commit-dates-parsing-fix' into maint
Codepaths that parse timestamps in commit objects have been
tightened.
* jk/commit-dates-parsing-fix:
show_ident_date: fix tz range check
log: do not segfault on gmtime errors
log: handle integer overflow in timestamps
date: check date overflow against time_t
fsck: report integer overflow in author timestamps
t4212: test bogus timestamps with git-log
Diffstat (limited to 'pretty.c')
-rw-r--r-- | pretty.c | 12 |
1 files changed, 9 insertions, 3 deletions
@@ -397,12 +397,18 @@ static const char *show_ident_date(const struct ident_split *ident, enum date_mode mode) { unsigned long date = 0; - int tz = 0; + long tz = 0; if (ident->date_begin && ident->date_end) date = strtoul(ident->date_begin, NULL, 10); - if (ident->tz_begin && ident->tz_end) - tz = strtol(ident->tz_begin, NULL, 10); + if (date_overflows(date)) + date = 0; + else { + if (ident->tz_begin && ident->tz_end) + tz = strtol(ident->tz_begin, NULL, 10); + if (tz >= INT_MAX || tz <= INT_MIN) + tz = 0; + } return show_date(date, tz, mode); } |