summaryrefslogtreecommitdiff
path: root/reachable.c
diff options
context:
space:
mode:
authorJohannes Schindelin <Johannes.Schindelin@gmx.de>2007-01-08 01:59:54 +0100
committerJunio C Hamano <junkio@cox.net>2007-01-09 03:04:04 -0800
commit883d60fa97c6397450fb129634054e0a6101baac (patch)
tree5596e3bc152a71b2fc9ba3161217740bb4d77b6d /reachable.c
parent1295228d1fdda17c2ef62e712649c962c3da5eb7 (diff)
downloadgit-883d60fa97c6397450fb129634054e0a6101baac.tar.gz
Sanitize for_each_reflog_ent()
It used to ignore the return value of the helper function; now, it expects it to return 0, and stops iteration upon non-zero return values; this value is then passed on as the return value of for_each_reflog_ent(). Further, it makes no sense to force the parsing upon the helper functions; for_each_reflog_ent() now calls the helper function with old and new sha1, the email, the timestamp & timezone, and the message. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'reachable.c')
-rw-r--r--reachable.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/reachable.c b/reachable.c
index 4dfee1dbe8..a6a334822a 100644
--- a/reachable.c
+++ b/reachable.c
@@ -104,7 +104,9 @@ static void walk_commit_list(struct rev_info *revs)
}
}
-static int add_one_reflog_ent(unsigned char *osha1, unsigned char *nsha1, char *datail, void *cb_data)
+static int add_one_reflog_ent(unsigned char *osha1, unsigned char *nsha1,
+ const char *email, unsigned long timestamp, int tz,
+ const char *message, void *cb_data)
{
struct object *object;
struct rev_info *revs = (struct rev_info *)cb_data;