diff options
| author | Sun He <sunheehnus@gmail.com> | 2014-03-03 17:39:59 +0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-03-06 14:03:12 -0800 |
| commit | 50546b15ed1df25837f8b291e6fa5bbcdb84635e (patch) | |
| tree | b2e93edbd6dd402b3a771173d5194adbdb5c235f /reflog-walk.c | |
| parent | 6ab4ae2b415c375170309c2b7ace0e4daa8d0215 (diff) | |
| download | git-50546b15ed1df25837f8b291e6fa5bbcdb84635e.tar.gz | |
Use hashcpy() when copying object namessh/use-hashcpy
We invented hashcpy() to keep the abstraction of "object name"
behind it. Use it instead of calling memcpy() with hard-coded
20-byte length when moving object names between pieces of memory.
Leave ppc/sha1.c as-is, because the function is about the SHA-1 hash
algorithm whose output is and will always be 20 bytes.
Helped-by: Michael Haggerty <mhagger@alum.mit.edu>
Helped-by: Duy Nguyen <pclouds@gmail.com>
Signed-off-by: Sun He <sunheehnus@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'reflog-walk.c')
| -rw-r--r-- | reflog-walk.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/reflog-walk.c b/reflog-walk.c index b2fbdb2392..d490f7d7d8 100644 --- a/reflog-walk.c +++ b/reflog-walk.c @@ -32,8 +32,8 @@ static int read_one_reflog(unsigned char *osha1, unsigned char *nsha1, sizeof(struct reflog_info)); } item = array->items + array->nr; - memcpy(item->osha1, osha1, 20); - memcpy(item->nsha1, nsha1, 20); + hashcpy(item->osha1, osha1); + hashcpy(item->nsha1, nsha1); item->email = xstrdup(email); item->timestamp = timestamp; item->tz = tz; |