diff options
author | Denton Liu <liu.denton@gmail.com> | 2019-04-29 04:28:14 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2019-05-05 15:20:06 +0900 |
commit | 554544276a604c144df45efcb060c80aa322088c (patch) | |
tree | ce55b3dc9ca47c326991ecfc06a2b1103f60be3a /reflog-walk.h | |
parent | ffac537e6cbbf934b08745a378932722df287a53 (diff) | |
download | git-554544276a604c144df45efcb060c80aa322088c.tar.gz |
*.[ch]: remove extern from function declarations using spatch
There has been a push to remove extern from function declarations.
Remove some instances of "extern" for function declarations which are
caught by Coccinelle. Note that Coccinelle has some difficulty with
processing functions with `__attribute__` or varargs so some `extern`
declarations are left behind to be dealt with in a future patch.
This was the Coccinelle patch used:
@@
type T;
identifier f;
@@
- extern
T f(...);
and it was run with:
$ git ls-files \*.{c,h} |
grep -v ^compat/ |
xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place
Files under `compat/` are intentionally excluded as some are directly
copied from external sources and we should avoid churning them as much
as possible.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'reflog-walk.h')
-rw-r--r-- | reflog-walk.h | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/reflog-walk.h b/reflog-walk.h index cb3e73755d..c83597d1db 100644 --- a/reflog-walk.h +++ b/reflog-walk.h @@ -6,21 +6,21 @@ struct commit; struct reflog_walk_info; -extern void init_reflog_walk(struct reflog_walk_info **info); -extern int add_reflog_for_walk(struct reflog_walk_info *info, +void init_reflog_walk(struct reflog_walk_info **info); +int add_reflog_for_walk(struct reflog_walk_info *info, struct commit *commit, const char *name); -extern void show_reflog_message(struct reflog_walk_info *info, int, +void show_reflog_message(struct reflog_walk_info *info, int, const struct date_mode *, int force_date); -extern void get_reflog_message(struct strbuf *sb, +void get_reflog_message(struct strbuf *sb, struct reflog_walk_info *reflog_info); -extern const char *get_reflog_ident(struct reflog_walk_info *reflog_info); -extern timestamp_t get_reflog_timestamp(struct reflog_walk_info *reflog_info); -extern void get_reflog_selector(struct strbuf *sb, +const char *get_reflog_ident(struct reflog_walk_info *reflog_info); +timestamp_t get_reflog_timestamp(struct reflog_walk_info *reflog_info); +void get_reflog_selector(struct strbuf *sb, struct reflog_walk_info *reflog_info, const struct date_mode *dmode, int force_date, int shorten); -extern int reflog_walk_empty(struct reflog_walk_info *walk); +int reflog_walk_empty(struct reflog_walk_info *walk); struct commit *next_reflog_entry(struct reflog_walk_info *reflog_info); |