diff options
| author | Thomas Rast <trast@student.ethz.ch> | 2010-06-10 14:54:03 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-06-12 09:34:17 -0700 |
| commit | 157aaea5fff7dbf2fc39829d827b35df647562a4 (patch) | |
| tree | 71edb7de89dc8740a4e00ad1d758a4abb9b6a1e3 /refs.h | |
| parent | 86e8e7a566c5546e58f56566d0181a08d60f919f (diff) | |
| download | git-157aaea5fff7dbf2fc39829d827b35df647562a4.tar.gz | |
log_ref_setup: don't return stack-allocated array
859c301 (refs: split log_ref_write logic into log_ref_setup,
2010-05-21) refactors the stack allocation of the log_file array into
the new log_ref_setup() function, but passes it back to the caller.
Since the original intent seems to have been to split the work between
log_ref_setup and log_ref_write, make it the caller's responsibility
to allocate the buffer.
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Reported-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'refs.h')
| -rw-r--r-- | refs.h | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -69,7 +69,7 @@ extern void unlock_ref(struct ref_lock *lock); extern int write_ref_sha1(struct ref_lock *lock, const unsigned char *sha1, const char *msg); /** Setup reflog before using. **/ -int log_ref_setup(const char *ref_name, char **log_file); +int log_ref_setup(const char *ref_name, char *logfile, int bufsize); /** Reads log for the value of ref during at_time. **/ extern int read_ref_at(const char *ref, unsigned long at_time, int cnt, unsigned char *sha1, char **msg, unsigned long *cutoff_time, int *cutoff_tz, int *cutoff_cnt); |