summaryrefslogtreecommitdiff
path: root/remote-curl.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2013-04-05 18:22:15 -0400
committerJunio C Hamano <gitster@pobox.com>2013-04-06 18:56:45 -0700
commitde89f0b25a42238948787421c0253228c006f7fa (patch)
tree295204103fdc6d9314f23ec0c4d4ba138abcbf01 /remote-curl.c
parent39a570f26c953e8277a6a26c00da657b240dcdd4 (diff)
downloadgit-de89f0b25a42238948787421c0253228c006f7fa.tar.gz
remote-curl: die directly with http error messages
When we encounter an unknown http error (e.g., a 403), we hand the error code to http_error, which then prints it with error(). After that we die with the redundant message "HTTP request failed". Instead, let's just drop http_error entirely, which does nothing but pass arguments to error(), and instead die directly with a useful message. So before: $ git clone https://example.com/repo.git Cloning into 'repo'... error: unable to access 'https://example.com/repo.git': The requested URL returned error: 403 Forbidden fatal: HTTP request failed and after: $ git clone https://example.com/repo.git Cloning into 'repo'... fatal: unable to access 'https://example.com/repo.git': The requested URL returned error: 403 Forbidden Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'remote-curl.c')
-rw-r--r--remote-curl.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/remote-curl.c b/remote-curl.c
index 9abe4b7116..60eda63081 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -216,8 +216,7 @@ static struct discovery* discover_refs(const char *service, int for_push)
die("Authentication failed for '%s'", url);
default:
show_http_message(&type, &buffer);
- http_error(url);
- die("HTTP request failed");
+ die("unable to access '%s': %s", url, curl_errorstr);
}
last= xcalloc(1, sizeof(*last_discovery));