summaryrefslogtreecommitdiff
path: root/remote.c
diff options
context:
space:
mode:
authorJohn Keeping <john@keeping.me.uk>2016-07-26 21:44:45 +0100
committerJunio C Hamano <gitster@pobox.com>2016-07-26 13:48:28 -0700
commit64ac39af7020f3a8bc52d51137804ce9f46baf66 (patch)
tree18af053411baadf7d5e040205a4377f4689b040c /remote.c
parenteee98e74f928a49c310038c77026ebc04e6cf4b2 (diff)
downloadgit-64ac39af7020f3a8bc52d51137804ce9f46baf66.tar.gz
push: allow pushing new branches with --force-with-lease
If there is no upstream information for a branch, it is likely that it is newly created and can safely be pushed under the normal fast-forward rules. Relax the --force-with-lease check so that we do not reject these branches immediately but rather attempt to push them as new branches, using the null SHA-1 as the expected value. In fact, it is already possible to push new branches using the explicit --force-with-lease=<branch>:<expect> syntax, so all we do here is make this behaviour the default if no explicit "expect" value is specified. Signed-off-by: John Keeping <john@keeping.me.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'remote.c')
-rw-r--r--remote.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/remote.c b/remote.c
index 29ecd3d8c5..3b6f4b7e6d 100644
--- a/remote.c
+++ b/remote.c
@@ -1554,8 +1554,7 @@ void set_ref_status_for_push(struct ref *remote_refs, int send_mirror,
* branch.
*/
if (ref->expect_old_sha1) {
- if (ref->expect_old_no_trackback ||
- oidcmp(&ref->old_oid, &ref->old_oid_expect))
+ if (oidcmp(&ref->old_oid, &ref->old_oid_expect))
reject_reason = REF_STATUS_REJECT_STALE;
else
/* If the ref isn't stale then force the update. */
@@ -2355,7 +2354,7 @@ static void apply_cas(struct push_cas_option *cas,
if (!entry->use_tracking)
hashcpy(ref->old_oid_expect.hash, cas->entry[i].expect);
else if (remote_tracking(remote, ref->name, &ref->old_oid_expect))
- ref->expect_old_no_trackback = 1;
+ oidclr(&ref->old_oid_expect);
return;
}
@@ -2365,7 +2364,7 @@ static void apply_cas(struct push_cas_option *cas,
ref->expect_old_sha1 = 1;
if (remote_tracking(remote, ref->name, &ref->old_oid_expect))
- ref->expect_old_no_trackback = 1;
+ oidclr(&ref->old_oid_expect);
}
void apply_push_cas(struct push_cas_option *cas,