diff options
author | Stefan Beller <stefanbeller@gmail.com> | 2014-08-10 23:33:26 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-08-12 11:00:33 -0700 |
commit | 81c3ce3cdce8dffb913243f5b2cc09d9fb966e6c (patch) | |
tree | 974a155e73dec708825519c9f21a44d678bc86ed /remote.c | |
parent | 32f56600bb6ac6fc57183e79d2c1515dfa56672f (diff) | |
download | git-81c3ce3cdce8dffb913243f5b2cc09d9fb966e6c.tar.gz |
prepare_revision_walk(): check for return value in all placessb/prepare-revision-walk-error-check
Even the documentation tells us:
You should check if it returns any error (non-zero return
code) and if it does not, you can start using get_revision()
to do the iteration.
In preparation for this commit, I grepped all occurrences of
prepare_revision_walk and added error messages, when there were none.
Signed-off-by: Stefan Beller <stefanbeller@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'remote.c')
-rw-r--r-- | remote.c | 3 |
1 files changed, 2 insertions, 1 deletions
@@ -1898,7 +1898,8 @@ int stat_tracking_info(struct branch *branch, int *num_ours, int *num_theirs) init_revisions(&revs, NULL); setup_revisions(rev_argc, rev_argv, &revs, NULL); - prepare_revision_walk(&revs); + if (prepare_revision_walk(&revs)) + die("revision walk setup failed"); /* ... and count the commits on each side. */ *num_ours = 0; |