diff options
author | Linus Torvalds <torvalds@osdl.org> | 2005-09-16 14:55:33 -0700 |
---|---|---|
committer | Junio C Hamano <junkio@cox.net> | 2005-09-16 15:32:23 -0700 |
commit | 8805ccac40348094d26b3b892c6ca3d08dc12ae0 (patch) | |
tree | b4465f53abbb399d7491f5b0060d9b5076f52794 /rev-list.c | |
parent | b0d8923ec01fd91b75ab079034f89ced91500157 (diff) | |
download | git-8805ccac40348094d26b3b892c6ca3d08dc12ae0.tar.gz |
[PATCH] Avoid building object ref lists when not needed
The object parsing code builds a generic "this object references that
object" because doing a full connectivity check for fsck requires it.
However, nothing else really needs it, and it's quite expensive for
git-rev-list that can have tons of objects in flight.
So, exactly like the commit buffer save thing, add a global flag to
disable it, and use it in git-rev-list.
Before:
$ /usr/bin/time git-rev-list --objects v2.6.12..HEAD | wc -l
12.28user 0.29system 0:12.57elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+26718minor)pagefaults 0swaps
59124
After this change:
$ /usr/bin/time git-rev-list --objects v2.6.12..HEAD | wc -l
10.33user 0.18system 0:10.54elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+18509minor)pagefaults 0swaps
59124
and note how the number of pages touched by git-rev-list for this
particular object list has shrunk from 26,718 (104 MB) to 18,509 (72 MB).
Calculating the total object difference between two git revisions is still
clearly the most expensive git operation (both in memory and CPU time),
but it's now less than 40% of what it used to be.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'rev-list.c')
-rw-r--r-- | rev-list.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/rev-list.c b/rev-list.c index 91534dd239..c55e912be4 100644 --- a/rev-list.c +++ b/rev-list.c @@ -581,6 +581,7 @@ int main(int argc, char **argv) } save_commit_buffer = verbose_header; + track_object_refs = 0; if (!merge_order) { sort_by_date(&list); |