diff options
| author | Jeff King <peff@peff.net> | 2012-02-02 03:20:10 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2012-02-02 10:36:08 -0800 |
| commit | c876d6da88d9bf1f3377d4eed66fc7705e31c30e (patch) | |
| tree | 84cc04ca18c5401bd1e9d05e72bbd1794c397e81 /revision.c | |
| parent | 8f24a6323ece9be1bf1a04b4b5856112438337f2 (diff) | |
| download | git-c876d6da88d9bf1f3377d4eed66fc7705e31c30e.tar.gz | |
grep: drop grep_buffer's "name" parameter
Before the grep_source interface existed, grep_buffer was
used by two types of callers:
1. Ones which pulled a file into a buffer, and then wanted
to supply the file's name for the output (i.e.,
git grep).
2. Ones which really just wanted to grep a buffer (i.e.,
git log --grep).
Callers in set (1) should now be using grep_source. Callers
in set (2) always pass NULL for the "name" parameter of
grep_buffer. We can therefore get rid of this now-useless
parameter.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'revision.c')
| -rw-r--r-- | revision.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/revision.c b/revision.c index 064e351084..89d3a8fafb 100644 --- a/revision.c +++ b/revision.c @@ -2128,7 +2128,6 @@ static int commit_match(struct commit *commit, struct rev_info *opt) if (!opt->grep_filter.pattern_list && !opt->grep_filter.header_list) return 1; return grep_buffer(&opt->grep_filter, - NULL, /* we say nothing, not even filename */ commit->buffer, strlen(commit->buffer)); } |