summaryrefslogtreecommitdiff
path: root/revision.c
diff options
context:
space:
mode:
authorDongcan Jiang <dongcan.jiang@gmail.com>2015-03-11 10:13:02 +0800
committerJunio C Hamano <gitster@pobox.com>2015-03-19 11:07:51 -0700
commit695985f4837e7299dca10b5e45206dbd2c52c1e0 (patch)
tree4dc6b51d89a4874c73a66f10b037f51218fee7bc /revision.c
parent9874fca7122563e28d699a911404fc49d2a24f1c (diff)
downloadgit-695985f4837e7299dca10b5e45206dbd2c52c1e0.tar.gz
revision: forbid combining --graph and --no-walkdj/log-graph-with-no-walk
Because "--graph" is about connected history while --no-walk is about discrete points, it does not make sense to allow these two options at the same time. [1] This change makes a few calls to "show --graph" fail in t4052, but asking to show one commit with graph is a nonsensical thing to do. Thus, tests on "show --graph" in t4052 have been removed [2,3]. Same tests on "show" without --graph option have already been tested in 4052. 3 testcases have been added to test this patch. [1]: http://article.gmane.org/gmane.comp.version-control.git/216083 [2]: http://article.gmane.org/gmane.comp.version-control.git/264950 [3]: http://article.gmane.org/gmane.comp.version-control.git/265107 Helped-By: Eric Sunshine <sunshine@sunshineco.com> Helped-By: René Scharfe <l.s.r@web.de> Helped-By: Junio C Hamano <gitster@pobox.com> Signed-off-by: Dongcan Jiang <dongcan.jiang@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'revision.c')
-rw-r--r--revision.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/revision.c b/revision.c
index 86406a26a2..f594a8d820 100644
--- a/revision.c
+++ b/revision.c
@@ -2337,6 +2337,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
if (revs->reflog_info && revs->graph)
die("cannot combine --walk-reflogs with --graph");
+ if (revs->no_walk && revs->graph)
+ die("cannot combine --no-walk with --graph");
if (!revs->reflog_info && revs->grep_filter.use_reflog_filter)
die("cannot use --grep-reflog without --walk-reflogs");