diff options
| author | Johannes Schindelin <Johannes.Schindelin@gmx.de> | 2008-07-23 01:51:36 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2008-08-01 23:14:22 -0700 |
| commit | 11ee57bc4c44763b7ea92c5f583e27a5fbbff76b (patch) | |
| tree | df239c6c08cd7cc778b6e404f5137cfc453b3f0f /revision.h | |
| parent | b1264da8637dc991b84e329c2c4958c1332d069f (diff) | |
| download | git-11ee57bc4c44763b7ea92c5f583e27a5fbbff76b.tar.gz | |
sort_in_topological_order(): avoid setting a commit flag
We used to set the TOPOSORT flag of commits during the topological
sorting, but we can just as well use the member "indegree" for it:
indegree is now incremented by 1 in the cases where the commit used
to have the TOPOSORT flag.
This is the same behavior as before, since indegree could not be
non-zero when TOPOSORT was unset.
Incidentally, this fixes the bug in show-branch where the 8th column
was not shown: show-branch sorts the commits in topological order,
assuming that all the commit flags are available for show-branch's
private matters.
But this was not true: TOPOSORT was identical to the flag corresponding
to the 8th ref. So the flags for the 8th column were unset by the
topological sorting.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'revision.h')
| -rw-r--r-- | revision.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/revision.h b/revision.h index abce5001f1..31f08c4056 100644 --- a/revision.h +++ b/revision.h @@ -10,7 +10,6 @@ #define CHILD_SHOWN (1u<<6) #define ADDED (1u<<7) /* Parents already parsed and added? */ #define SYMMETRIC_LEFT (1u<<8) -#define TOPOSORT (1u<<9) /* In the active toposort list.. */ struct rev_info; struct log_info; |