summaryrefslogtreecommitdiff
path: root/revision.h
diff options
context:
space:
mode:
authorKevin Bracey <kevin@bracey.fi>2013-05-13 18:00:47 +0300
committerJunio C Hamano <gitster@pobox.com>2013-05-16 11:45:34 -0700
commita765499a0884375c47c78d0d1e2926e875074427 (patch)
tree2ef7689495516b64b25f213a4150a43afd7a6199 /revision.h
parentf659031c1ceb979d423161541a8a3763bfd7c96c (diff)
downloadgit-a765499a0884375c47c78d0d1e2926e875074427.tar.gz
revision.c: treat A...B merge bases as if manually specified
The documentation assures users that "A...B" is defined as "A B --not $(git merge-base --all A B)". This wasn't in fact quite true, because the calculated merge bases were not sent to add_rev_cmdline(). The main effect of this was that although git rev-list --ancestry-path A B --not $(git merge-base --all A B) worked, the simpler form git rev-list --ancestry-path A...B failed with a "no bottom commits" error. Other potential users of bottom commits could also be affected by this problem, if they examine revs->cmdline_info; I came across the issue in my proposed history traversal refinements series. So ensure that the calculated merge bases are sent to add_rev_cmdline(), flagged with new 'whence' enum value REV_CMD_MERGE_BASE. Signed-off-by: Kevin Bracey <kevin@bracey.fi> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'revision.h')
-rw-r--r--revision.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/revision.h b/revision.h
index 01bd2b7c07..878a5556fd 100644
--- a/revision.h
+++ b/revision.h
@@ -35,6 +35,7 @@ struct rev_cmdline_info {
REV_CMD_PARENTS_ONLY,
REV_CMD_LEFT,
REV_CMD_RIGHT,
+ REV_CMD_MERGE_BASE,
REV_CMD_REV
} whence;
unsigned flags;