summaryrefslogtreecommitdiff
path: root/submodule.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2013-01-23 01:25:07 -0500
committerJunio C Hamano <gitster@pobox.com>2013-01-23 08:41:51 -0800
commit0a5987fe5e0cea23245e0beab6eb47131864b276 (patch)
tree47181a75625ec08713957c10817916d9b2fb8323 /submodule.c
parentd731f0ade129a71237eff5a17f3196002cb439fb (diff)
downloadgit-0a5987fe5e0cea23245e0beab6eb47131864b276.tar.gz
userdiff: drop parse_driver function
When we parse userdiff config, we generally assume that diff.name.key will affect the "key" value of the "name" driver. However, without confirming that the key is a valid userdiff key, we may accidentally conflict with the ancient "diff.color.*" namespace. The current code is careful not to even create a driver struct if we do not see a key that is known by the diff-driver code. However, this carefulness is unnecessary; the default driver with no keys set behaves exactly the same as having no driver at all. We can simply set up the driver struct as soon as we see we have a config key that looks like a driver. This makes the code a bit more readable. Signed-off-by: Jeff King <peff@peff.net> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'submodule.c')
0 files changed, 0 insertions, 0 deletions