summaryrefslogtreecommitdiff
path: root/submodule.c
diff options
context:
space:
mode:
authorTanay Abhra <tanayabh@gmail.com>2014-07-18 02:19:00 -0700
committerJunio C Hamano <gitster@pobox.com>2014-07-21 10:23:44 -0700
commitf93d7c6fa0548e95ca2795d900671a87c1a88ea3 (patch)
tree1136bcbd0c89c5d40312c5663804530de12a490b /submodule.c
parent3ed3f5fe85ac3fa7f94ccaab59408a20db8c7a41 (diff)
downloadgit-f93d7c6fa0548e95ca2795d900671a87c1a88ea3.tar.gz
replace memset with string-list initializersta/string-list-init
Using memset and then manually setting values of the string-list members is not future proof as the internal representation of string-list may change any time. Use `string_list_init()` or STRING_LIST_INIT_* macros instead of memset. Signed-off-by: Tanay Abhra <tanayabh@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'submodule.c')
-rw-r--r--submodule.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/submodule.c b/submodule.c
index b80ecacf60..2fe2ad8ee4 100644
--- a/submodule.c
+++ b/submodule.c
@@ -544,10 +544,7 @@ static int push_submodule(const char *path)
int push_unpushed_submodules(unsigned char new_sha1[20], const char *remotes_name)
{
int i, ret = 1;
- struct string_list needs_pushing;
-
- memset(&needs_pushing, 0, sizeof(struct string_list));
- needs_pushing.strdup_strings = 1;
+ struct string_list needs_pushing = STRING_LIST_INIT_DUP;
if (!find_unpushed_submodules(new_sha1, remotes_name, &needs_pushing))
return 1;