diff options
| author | Stefan Beller <sbeller@google.com> | 2016-02-29 13:57:06 -0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-02-29 14:20:09 -0800 |
| commit | c4c02f56c22ef8ba88e6c936cb3f25f6af7ec456 (patch) | |
| tree | 336cc9359744a3318118ed83a1fe304782fc8b07 /submodule.c | |
| parent | 62104ba14af4845c6c1ba1dab05fad4a289d806f (diff) | |
| download | git-sb/no-child-process-access-in-run-parallel-callbacks.tar.gz | |
run-command: do not pass child process data into callbackssb/no-child-process-access-in-run-parallel-callbacks
The expected way to pass data into the callback is to pass them via
the customizable callback pointer. The error reporting in
default_{start_failure, task_finished} is not user friendly enough, that
we want to encourage using the child data for such purposes.
Furthermore the struct child data is cleaned by the run-command API,
before we access them in the callbacks, leading to use-after-free
situations.
Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'submodule.c')
| -rw-r--r-- | submodule.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/submodule.c b/submodule.c index b83939c294..916fc84aaa 100644 --- a/submodule.c +++ b/submodule.c @@ -705,8 +705,7 @@ static int get_next_submodule(struct child_process *cp, return 0; } -static int fetch_start_failure(struct child_process *cp, - struct strbuf *err, +static int fetch_start_failure(struct strbuf *err, void *cb, void *task_cb) { struct submodule_parallel_fetch *spf = cb; @@ -716,8 +715,8 @@ static int fetch_start_failure(struct child_process *cp, return 0; } -static int fetch_finish(int retvalue, struct child_process *cp, - struct strbuf *err, void *cb, void *task_cb) +static int fetch_finish(int retvalue, struct strbuf *err, + void *cb, void *task_cb) { struct submodule_parallel_fetch *spf = cb; |