diff options
author | Jonathan Nieder <jrnieder@gmail.com> | 2010-10-30 20:46:54 -0500 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2010-11-09 11:59:49 -0800 |
commit | a48fcd836971d065b9bf16b8cd046fd1aff9b279 (patch) | |
tree | 34f868252e96a6cf1f7fe02014977f7fbb12d4c3 /t/t0050-filesystem.sh | |
parent | 00648ba0505bbe1999bb6ae2f1d02a0ef923b191 (diff) | |
download | git-a48fcd836971d065b9bf16b8cd046fd1aff9b279.tar.gz |
tests: add missing &&
Breaks in a test assertion's && chain can potentially hide
failures from earlier commands in the chain.
Commands intended to fail should be marked with !, test_must_fail, or
test_might_fail. The examples in this patch do not require that.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t0050-filesystem.sh')
-rwxr-xr-x | t/t0050-filesystem.sh | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh index 41df6bcf27..057c97c49f 100755 --- a/t/t0050-filesystem.sh +++ b/t/t0050-filesystem.sh @@ -12,14 +12,14 @@ unibad= no_symlinks= test_expect_success 'see what we expect' ' - test_case=test_expect_success - test_unicode=test_expect_success + test_case=test_expect_success && + test_unicode=test_expect_success && mkdir junk && echo good >junk/CamelCase && echo bad >junk/camelcase && if test "$(cat junk/CamelCase)" != good then - test_case=test_expect_failure + test_case=test_expect_failure && case_insensitive=t fi && rm -fr junk && @@ -27,7 +27,7 @@ test_expect_success 'see what we expect' ' >junk/"$auml" && case "$(cd junk && echo *)" in "$aumlcdiar") - test_unicode=test_expect_failure + test_unicode=test_expect_failure && unibad=t ;; *) ;; @@ -36,7 +36,7 @@ test_expect_success 'see what we expect' ' { ln -s x y 2> /dev/null && test -h y 2> /dev/null || - no_symlinks=1 + no_symlinks=1 && rm -f y } ' @@ -128,7 +128,7 @@ test_expect_success "setup unicode normalization tests" ' cd unicode && touch "$aumlcdiar" && git add "$aumlcdiar" && - git commit -m initial + git commit -m initial && git tag initial && git checkout -b topic && git mv $aumlcdiar tmp && |