diff options
| author | Eric Sunshine <sunshine@sunshineco.com> | 2021-12-09 00:11:12 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2021-12-13 10:29:48 -0800 |
| commit | db5875aa9fe056c2db3a463989091c5f70d6c8d1 (patch) | |
| tree | 7009932d4396e0928ca5926ac985e30f1dcce33a /t/t1403-show-ref.sh | |
| parent | efe26b9ee09d53dda0f36d0ea20cb245b934f216 (diff) | |
| download | git-db5875aa9fe056c2db3a463989091c5f70d6c8d1.tar.gz | |
t0000-t3999: detect and signal failure within loop
Failures within `for` and `while` loops can go unnoticed if not detected
and signaled manually since the loop itself does not abort when a
contained command fails, nor will a failure necessarily be detected when
the loop finishes since the loop returns the exit code of the last
command it ran on the final iteration, which may not be the command
which failed. Therefore, detect and signal failures manually within
loops using the idiom `|| return 1` (or `|| exit 1` within subshells).
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t1403-show-ref.sh')
| -rwxr-xr-x | t/t1403-show-ref.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/t/t1403-show-ref.sh b/t/t1403-show-ref.sh index bbc01aae34..405da58b75 100755 --- a/t/t1403-show-ref.sh +++ b/t/t1403-show-ref.sh @@ -123,14 +123,14 @@ test_expect_success 'show-ref -d' ' test_expect_success 'show-ref --heads, --tags, --head, pattern' ' for branch in B main side do - echo $(git rev-parse refs/heads/$branch) refs/heads/$branch + echo $(git rev-parse refs/heads/$branch) refs/heads/$branch || return 1 done >expect.heads && git show-ref --heads >actual && test_cmp expect.heads actual && for tag in A B C do - echo $(git rev-parse refs/tags/$tag) refs/tags/$tag + echo $(git rev-parse refs/tags/$tag) refs/tags/$tag || return 1 done >expect.tags && git show-ref --tags >actual && test_cmp expect.tags actual && |