diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2018-01-30 21:21:20 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2018-01-30 14:04:01 -0800 |
| commit | 4bc280f25098c60c7e6eef4b0277a94925ed4c11 (patch) | |
| tree | ffb2865c32fb6a92108d4ca195264178c3ce33b1 /t/t3070-wildmatch.sh | |
| parent | 50eafb1a278d20a55280880ac6a24f5981eac6df (diff) | |
| download | git-4bc280f25098c60c7e6eef4b0277a94925ed4c11.tar.gz | |
wildmatch test: use test_must_fail, not ! for test-wildmatch
Use of ! should be reserved for non-git programs that are assumed not
to fail, see README. With this change only
t/t0110-urlmatch-normalization.sh is still using this anti-pattern.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t3070-wildmatch.sh')
| -rwxr-xr-x | t/t3070-wildmatch.sh | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh index 2f8a681c72..fe0e5103a3 100755 --- a/t/t3070-wildmatch.sh +++ b/t/t3070-wildmatch.sh @@ -13,7 +13,7 @@ match() { elif test "$1" = 0 then test_expect_success "wildmatch: no match '$2' '$3'" " - ! test-wildmatch wildmatch '$2' '$3' + test_must_fail test-wildmatch wildmatch '$2' '$3' " else test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false' @@ -29,7 +29,7 @@ imatch() { elif test "$1" = 0 then test_expect_success "iwildmatch: no match '$2' '$3'" " - ! test-wildmatch iwildmatch '$2' '$3' + test_must_fail test-wildmatch iwildmatch '$2' '$3' " else test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false' @@ -45,7 +45,7 @@ pathmatch() { elif test "$1" = 0 then test_expect_success "pathmatch: no match '$2' '$3'" " - ! test-wildmatch pathmatch '$2' '$3' + test_must_fail test-wildmatch pathmatch '$2' '$3' " else test_expect_success "PANIC: Test framework error. Unknown matches value $1" 'false' |