diff options
| author | Brandon Casey <drafnel@gmail.com> | 2010-03-19 19:10:20 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-03-20 08:22:32 -0700 |
| commit | 49de47cfb2d717b64cf93c5abeeefb87ee483de0 (patch) | |
| tree | ee50e43d7e17a6d4b3cc8c87fa853efcc3859c39 /t/t5505-remote.sh | |
| parent | f3b1fbf8602e9038ee12a44bbd71b49e6ab59fe1 (diff) | |
| download | git-49de47cfb2d717b64cf93c5abeeefb87ee483de0.tar.gz | |
t/t5505-remote.sh: escape * to prevent interpretation by shell as glob
This test is supposed to check that git-remote correctly refuses to delete
all URLS for the specified remote which match the '.*' regular expression.
Since the '*' was not protected, it was interpreted by the shell as a file
glob and expanded before being passed to git-remote. The call to
git-remote still exited non-zero in this case, and the overall test still
passed, but it exited non-zero because git-remote was passed the incorrect
number of arguments, not for the reason it was supposed to fail.
Correct the test by escaping the '*'.
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5505-remote.sh')
| -rwxr-xr-x | t/t5505-remote.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh index e7afe9e16e..acfea06b81 100755 --- a/t/t5505-remote.sh +++ b/t/t5505-remote.sh @@ -662,7 +662,7 @@ test_expect_success 'remote set-url --add bbb' ' ' test_expect_success 'remote set-url --delete .*' ' - test_must_fail git remote set-url --delete someremote .* && + test_must_fail git remote set-url --delete someremote .\* && echo "YYY" >expect && echo baz >>expect && echo bbb >>expect && |