diff options
author | Johan Herland <johan@herland.net> | 2013-04-21 23:52:04 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2013-04-21 15:14:41 -0700 |
commit | 983b17d4bbedd426d4fdd8a95df4dcd292c1a695 (patch) | |
tree | c82b5ef83e8873a3676ab5368aafbc72458b4a70 /t/t9114-git-svn-dcommit-merge.sh | |
parent | 88a9f72fe0f2ae3243b3d7a53dddf856cde48aca (diff) | |
download | git-983b17d4bbedd426d4fdd8a95df4dcd292c1a695.tar.gz |
t9114.2: Don't use --track option against "svn-remote"-tracking branches
We are formalizing a requirement that any remote-tracking branch to be used
as an upstream (i.e. as an argument to --track), _must_ "belong" to a
configured remote by being matched by the "dst" side of a fetch refspec.
This test uses --track against a "remotes/trunk" ref which does not belong
to any configured (git) remotes, but is instead created by "git svn fetch"
operating on an svn-remote. It does not make sense to use an svn-remote as
an upstream for a local branch, as a regular "git pull" from (or "git push"
to) it would obviously fail (instead you would need to use "git svn" to
communicate with this remote). Furthermore, the usage of --track in this
case is unnecessary, since the upstreaming config that would be created is
never used.
Simply removing --track fixes the issue without changing the expected
behavior of the test.
Acked-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t9114-git-svn-dcommit-merge.sh')
-rwxr-xr-x | t/t9114-git-svn-dcommit-merge.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t9114-git-svn-dcommit-merge.sh b/t/t9114-git-svn-dcommit-merge.sh index 3077851015..f524d2f383 100755 --- a/t/t9114-git-svn-dcommit-merge.sh +++ b/t/t9114-git-svn-dcommit-merge.sh @@ -48,7 +48,7 @@ test_expect_success 'setup svn repository' ' test_expect_success 'setup git mirror and merge' ' git svn init "$svnrepo" -t tags -T trunk -b branches && git svn fetch && - git checkout --track -b svn remotes/trunk && + git checkout -b svn remotes/trunk && git checkout -b merge && echo new file > new_file && git add new_file && |