diff options
| author | Eric Sunshine <sunshine@sunshineco.com> | 2021-12-09 00:11:15 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2021-12-13 10:29:48 -0800 |
| commit | 0c51d6b4aec9f1959d148960cb55155b676cec78 (patch) | |
| tree | 3b7e70327191ff2a03ec8aacb7f951fb72cb978c /t/t9130-git-svn-authors-file.sh | |
| parent | d0fd993137cf41be66b54628f124b6651eea0bd2 (diff) | |
| download | git-0c51d6b4aec9f1959d148960cb55155b676cec78.tar.gz | |
t6000-t9999: detect and signal failure within loop
Failures within `for` and `while` loops can go unnoticed if not detected
and signaled manually since the loop itself does not abort when a
contained command fails, nor will a failure necessarily be detected when
the loop finishes since the loop returns the exit code of the last
command it ran on the final iteration, which may not be the command
which failed. Therefore, detect and signal failures manually within
loops using the idiom `|| return 1` (or `|| exit 1` within subshells).
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t9130-git-svn-authors-file.sh')
| -rwxr-xr-x | t/t9130-git-svn-authors-file.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/t/t9130-git-svn-authors-file.sh b/t/t9130-git-svn-authors-file.sh index b4081fefba..90325db909 100755 --- a/t/t9130-git-svn-authors-file.sh +++ b/t/t9130-git-svn-authors-file.sh @@ -15,7 +15,7 @@ EOF test_expect_success 'setup svnrepo' ' for i in aa bb cc dd do - svn_cmd mkdir -m $i --username $i "$svnrepo"/$i + svn_cmd mkdir -m $i --username $i "$svnrepo"/$i || return 1 done ' @@ -60,7 +60,7 @@ test_expect_success 'authors-file against globs' ' for i in bb ee cc do branch="aa/branches/$i" && - svn_cmd mkdir -m "$branch" --username $i "$svnrepo/$branch" + svn_cmd mkdir -m "$branch" --username $i "$svnrepo/$branch" || return 1 done ' |