diff options
author | Linus Torvalds <torvalds@osdl.org> | 2007-01-11 20:23:00 -0800 |
---|---|---|
committer | Junio C Hamano <junkio@cox.net> | 2007-01-11 21:02:58 -0800 |
commit | d34cf19b8987ae0f0806e257edf877238d044747 (patch) | |
tree | 62c54c75d209587d44efc0528bd04d7cd8a8f472 /tar.h | |
parent | 9bbaa6cc6848b68b8bef681c2a22b57bbec3e914 (diff) | |
download | git-d34cf19b8987ae0f0806e257edf877238d044747.tar.gz |
Clean up write_in_full() users
With the new-and-improved write_in_full() semantics, where a partial write
simply always returns a real error (and always sets 'errno' when that
happens, including for the disk full case), a lot of the callers of
write_in_full() were just unnecessarily complex.
In particular, there's no reason to ever check for a zero length or
return: if the length was zero, we'll return zero, otherwise, if a disk
full resulted in the actual write() system call returning zero the
write_in_full() logic would have correctly turned that into a negative
return value, with 'errno' set to ENOSPC.
I really wish every "write_in_full()" user would just check against "<0"
now, but this fixes the nasty and stupid ones.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'tar.h')
0 files changed, 0 insertions, 0 deletions