diff options
| author | Jeff King <peff@peff.net> | 2014-05-20 02:49:20 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-05-20 11:09:03 -0700 |
| commit | dd63f169d9381a77db469325688a2bef1a79a9e1 (patch) | |
| tree | 9f67675b9d77ce9ec6cf4003b8b57181915d86de /test-urlmatch-normalization.c | |
| parent | 7bbc4e8fdb33e0a8e42e77cc05460d4c4f615f4d (diff) | |
| download | git-dd63f169d9381a77db469325688a2bef1a79a9e1.tar.gz | |
move "--follow needs one pathspec" rule to diff_setup_donejk/diff-follow-must-take-one-pathspec
Because of the way "--follow" is implemented, we must have
exactly one pathspec. "git log" enforces this restriction,
but other users of the revision traversal code do not. For
example, "git format-patch --follow" will segfault during
try_to_follow_renames, as we have no pathspecs at all.
We can push this check down into diff_setup_done, which is
probably a better place anyway. It is the diff code that
introduces this restriction, so other parts of the code
should not need to care themselves.
Reported-by: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'test-urlmatch-normalization.c')
0 files changed, 0 insertions, 0 deletions