diff options
author | Jeff King <peff@peff.net> | 2014-06-18 15:46:15 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-06-20 10:44:44 -0700 |
commit | ff45c0d4a316d620d118ec628dd8e78597a23321 (patch) | |
tree | f1d6e5018ef25b0b0b3f79fa0cbbf7508a0a3bf3 /transport-helper.c | |
parent | ce2ecf29241ca90655da37918044cbbaff48a2bd (diff) | |
download | git-ff45c0d4a316d620d118ec628dd8e78597a23321.tar.gz |
fast-import: fix read of uninitialized argv memory
Fast-import shares code between its command-line parser and
the "option" command. To do so, it strips the "--" from any
command-line options and passes them to the option parser.
However, it does not confirm that the option even begins
with "--" before blindly passing "arg + 2".
It does confirm that the option starts with "-", so the only
affected case was:
git fast-import -
which would read uninitialized memory after the argument. We
can fix it by using skip_prefix and checking the result. As
a bonus, this gets rid of some magic numbers.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'transport-helper.c')
0 files changed, 0 insertions, 0 deletions