diff options
| author | Shawn O. Pearce <spearce@spearce.org> | 2007-01-14 01:01:49 -0500 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2007-01-14 00:42:41 -0800 |
| commit | e6e2bd6201d32342df7a713c847161ab296885ea (patch) | |
| tree | 1d1e4220abd26adccf9476fdeaa8ae358b27d506 /write_or_die.c | |
| parent | 38434f2eed45f42ed706d07564079c23ee686511 (diff) | |
| download | git-e6e2bd6201d32342df7a713c847161ab296885ea.tar.gz | |
Remove read_or_die in favor of better error messages.
Originally I introduced read_or_die for the purpose of reading
the pack header and trailer, and I was too lazy to print proper
error messages.
Linus Torvalds <torvalds@osdl.org>:
> For a read error, at the very least you have to say WHICH FILE
> couldn't be read, because it's usually a matter of some file just
> being too short, not some system-wide problem.
and of course Linus is right. Make it so.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'write_or_die.c')
| -rw-r--r-- | write_or_die.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/write_or_die.c b/write_or_die.c index 4e8183e93e..046e79d485 100644 --- a/write_or_die.c +++ b/write_or_die.c @@ -17,18 +17,6 @@ int read_in_full(int fd, void *buf, size_t count) return total; } -void read_or_die(int fd, void *buf, size_t count) -{ - ssize_t loaded; - - loaded = read_in_full(fd, buf, count); - if (loaded != count) { - if (loaded < 0) - die("read error (%s)", strerror(errno)); - die("read error: end of file"); - } -} - int write_in_full(int fd, const void *buf, size_t count) { const char *p = buf; |