From 1b09073514085c51bbd2884122af60a45b24db5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Scharfe?= Date: Thu, 7 Dec 2017 21:20:19 +0100 Subject: am: release strbuf after use in split_mail_mbox() Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano --- builtin/am.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/builtin/am.c b/builtin/am.c index 1399c8dd88..2368853763 100644 --- a/builtin/am.c +++ b/builtin/am.c @@ -702,6 +702,7 @@ static int split_mail_mbox(struct am_state *state, const char **paths, int keep_ { struct child_process cp = CHILD_PROCESS_INIT; struct strbuf last = STRBUF_INIT; + int ret; cp.git_cmd = 1; argv_array_push(&cp.args, "mailsplit"); @@ -713,13 +714,16 @@ static int split_mail_mbox(struct am_state *state, const char **paths, int keep_ argv_array_push(&cp.args, "--"); argv_array_pushv(&cp.args, paths); - if (capture_command(&cp, &last, 8)) - return -1; + ret = capture_command(&cp, &last, 8); + if (ret) + goto exit; state->cur = 1; state->last = strtol(last.buf, NULL, 10); - return 0; +exit: + strbuf_release(&last); + return ret ? -1 : 0; } /** -- cgit v1.2.1