From 9a9592ff7c8a8f0e449515c158e4a5a4895c5c23 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Sun, 22 Mar 2015 06:00:01 -0400 Subject: wt-status: don't flush before running "submodule status" This is a holdover from the original implementation in ac8d5af (builtin-status: submodule summary support, 2008-04-12), which just had the sub-process output to our descriptor; we had to make sure we had flushed any data that we produced before it started writing. Since 3ba7407 (submodule summary: ignore --for-status option, 2013-09-06), however, we pipe the sub-process output back to ourselves. So there's no longer any need to flush (it does not hurt, but it may leave readers wondering why we do it). Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- wt-status.c | 1 - 1 file changed, 1 deletion(-) diff --git a/wt-status.c b/wt-status.c index 29666d0dba..08d40d202e 100644 --- a/wt-status.c +++ b/wt-status.c @@ -745,7 +745,6 @@ static void wt_status_print_submodule_summary(struct wt_status *s, int uncommitt sm_summary.git_cmd = 1; sm_summary.no_stdin = 1; - fflush(s->fp); sm_summary.out = -1; run_command(&sm_summary); -- cgit v1.2.1