From afe2fab72c3151d02314ab5ef3708cd203c499e5 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Sun, 17 Sep 2017 12:16:55 +0900 Subject: gc: call fscanf() with %s, not %c, when reading hostname Earlier in this codepath, we (ab)used "%c" to read the hostname recorded in the lockfile into locking_host[HOST_NAME_MAX + 1] while substituting with the actual value of HOST_NAME_MAX. This turns out to be incorrect, as it is an instruction to read exactly the specified number of bytes. Because we are trying to read at most that many bytes, we should be using "%s" instead. Helped-by: A. Wilcox Signed-off-by: Junio C Hamano --- builtin/gc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/gc.c b/builtin/gc.c index 5befd518fd..22b35a627e 100644 --- a/builtin/gc.c +++ b/builtin/gc.c @@ -244,7 +244,7 @@ static const char *lock_repo_for_gc(int force, pid_t* ret_pid) int should_exit; if (!scan_fmt) - scan_fmt = xstrfmt("%s %%%dc", "%"SCNuMAX, HOST_NAME_MAX); + scan_fmt = xstrfmt("%s %%%ds", "%"SCNuMAX, HOST_NAME_MAX); fp = fopen(pidfile_path, "r"); memset(locking_host, 0, sizeof(locking_host)); should_exit = -- cgit v1.2.1