From 83c31614ceae2612b7cdba40e6401716fe854cd2 Mon Sep 17 00:00:00 2001 From: Robert Shearman Date: Thu, 27 Jul 2006 10:32:25 +0100 Subject: rebase: Fix the detection of fast-forwarding of the current branch to upstream. Previously, a rebasing operation with on a branch that is just tracking an upstream branch would output a confusing "Nothing to do" due to no patches being given to git-am. The test brings the behaviour back into line with that of just before e646c9c8c0aa995eac284ea0a2117add19c4461c. Signed-off-by: Robert Shearman Signed-off-by: Junio C Hamano --- git-rebase.sh | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/git-rebase.sh b/git-rebase.sh index 29028dd5fc..240032f32d 100755 --- a/git-rebase.sh +++ b/git-rebase.sh @@ -266,14 +266,11 @@ onto=$(git-rev-parse --verify "${onto_name}^0") || exit # Check if we are already based on $onto, but this should be # done only when upstream and onto are the same. -if test "$upstream" = "$onto" +mb=$(git-merge-base "$onto" "$branch") +if test "$upstream" = "$onto" && test "$mb" = "$onto" then - mb=$(git-merge-base "$onto" "$branch") - if test "$mb" = "$onto" - then - echo >&2 "Current branch $branch_name is up to date." - exit 0 - fi + echo >&2 "Current branch $branch_name is up to date." + exit 0 fi # Rewind the head to "$onto"; this saves our current head in ORIG_HEAD. @@ -281,7 +278,7 @@ git-reset --hard "$onto" # If the $onto is a proper descendant of the tip of the branch, then # we just fast forwarded. -if test "$mb" = "$onto" +if test "$mb" = "$branch" then echo >&2 "Fast-forwarded $branch to $newbase." exit 0 -- cgit v1.2.1 From d587ed13bc37550a6d21067127f6c057c5d5e7fc Mon Sep 17 00:00:00 2001 From: Robert Shearman Date: Thu, 27 Jul 2006 10:32:46 +0100 Subject: rebase: Make the fast-fowarding message more user-friendly by using branch names instead of SHA1 IDs. Signed-off-by: Robert Shearman Signed-off-by: Junio C Hamano --- git-rebase.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-rebase.sh b/git-rebase.sh index 240032f32d..7d3a5d0e71 100755 --- a/git-rebase.sh +++ b/git-rebase.sh @@ -280,7 +280,7 @@ git-reset --hard "$onto" # we just fast forwarded. if test "$mb" = "$branch" then - echo >&2 "Fast-forwarded $branch to $newbase." + echo >&2 "Fast-forwarded $branch_name to $onto_name." exit 0 fi -- cgit v1.2.1