From d962ab2d01c11f4e6a98f79100b93f6412495501 Mon Sep 17 00:00:00 2001 From: "Tom G. Christensen" Date: Fri, 30 Jan 2015 07:24:45 +0100 Subject: t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-' The '--no-xmailer' option is a Getopt::Long boolean option. The '--no-' prefix (as in --no-xmailer) for boolean options is not supported in Getopt::Long version 2.32 which was released with Perl 5.8.0. This version only supports '--no' as in '--noxmailer'. More recent versions of Getopt::Long, such as version 2.34, support either prefix. So use the older form in the tests. We have fixed the same kind of issue a few times, e.g. d2559f73 (t9001: 2010-12-22) 907a0b1e (t9001: 2009-12-03) 84eeb687 (t9001: 2009-04-24) 3fee1fe8 (t9001: 2008-10-10) Signed-off-by: Tom G. Christensen Signed-off-by: Junio C Hamano --- t/t9001-send-email.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index af6a3e8904..30df6aead0 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -1580,20 +1580,20 @@ do_xmailer_test () { test_expect_success $PREREQ '--[no-]xmailer without any configuration' ' do_xmailer_test 1 "--xmailer" && - do_xmailer_test 0 "--no-xmailer" + do_xmailer_test 0 "--noxmailer" ' test_expect_success $PREREQ '--[no-]xmailer with sendemail.xmailer=true' ' test_config sendemail.xmailer true && do_xmailer_test 1 "" && - do_xmailer_test 0 "--no-xmailer" && + do_xmailer_test 0 "--noxmailer" && do_xmailer_test 1 "--xmailer" ' test_expect_success $PREREQ '--[no-]xmailer with sendemail.xmailer=false' ' test_config sendemail.xmailer false && do_xmailer_test 0 "" && - do_xmailer_test 0 "--no-xmailer" && + do_xmailer_test 0 "--noxmailer" && do_xmailer_test 1 "--xmailer" ' -- cgit v1.2.1