From 554544276a604c144df45efcb060c80aa322088c Mon Sep 17 00:00:00 2001 From: Denton Liu Date: Mon, 29 Apr 2019 04:28:14 -0400 Subject: *.[ch]: remove extern from function declarations using spatch There has been a push to remove extern from function declarations. Remove some instances of "extern" for function declarations which are caught by Coccinelle. Note that Coccinelle has some difficulty with processing functions with `__attribute__` or varargs so some `extern` declarations are left behind to be dealt with in a future patch. This was the Coccinelle patch used: @@ type T; identifier f; @@ - extern T f(...); and it was run with: $ git ls-files \*.{c,h} | grep -v ^compat/ | xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place Files under `compat/` are intentionally excluded as some are directly copied from external sources and we should avoid churning them as much as possible. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano --- bisect.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'bisect.h') diff --git a/bisect.h b/bisect.h index 821d16e4dd..81ac43baa7 100644 --- a/bisect.h +++ b/bisect.h @@ -11,10 +11,10 @@ struct repository; * Otherwise, it will be either all non-SAMETREE commits or the single * best commit, as chosen by `find_all`. */ -extern void find_bisection(struct commit_list **list, int *reaches, int *all, +void find_bisection(struct commit_list **list, int *reaches, int *all, int find_all); -extern struct commit_list *filter_skipped(struct commit_list *list, +struct commit_list *filter_skipped(struct commit_list *list, struct commit_list **tried, int show_all, int *count, @@ -31,14 +31,14 @@ struct rev_list_info { const char *header_prefix; }; -extern int bisect_next_all(struct repository *r, +int bisect_next_all(struct repository *r, const char *prefix, int no_checkout); -extern int estimate_bisect_steps(int all); +int estimate_bisect_steps(int all); -extern void read_bisect_terms(const char **bad, const char **good); +void read_bisect_terms(const char **bad, const char **good); -extern int bisect_clean_state(void); +int bisect_clean_state(void); #endif -- cgit v1.2.1