From 5f2b643e76d9a1330c1a02489c0787ca7d818633 Mon Sep 17 00:00:00 2001 From: "Randall S. Becker" Date: Fri, 19 Jun 2020 16:23:20 -0400 Subject: strbuf: remove unreferenced strbuf_write_fd method. strbuf_write_fd was only used in bugreport.c. Since that file now uses write_in_full, this method is no longer needed. In addition, strbuf_write_fd did not guard against exceeding MAX_IO_SIZE for the platform, nor provided error handling in the event of a failure if only partial data was written to the file descriptor. Since already write_in_full has this capability and is in general use, it should be used instead. The change impacts strbuf.c and strbuf.h. Signed-off-by: Randall S. Becker Signed-off-by: Junio C Hamano --- strbuf.h | 1 - 1 file changed, 1 deletion(-) (limited to 'strbuf.h') diff --git a/strbuf.h b/strbuf.h index 1eaa944a4f..bfa66569a4 100644 --- a/strbuf.h +++ b/strbuf.h @@ -450,7 +450,6 @@ int strbuf_readlink(struct strbuf *sb, const char *path, size_t hint); * NUL bytes. */ ssize_t strbuf_write(struct strbuf *sb, FILE *stream); -ssize_t strbuf_write_fd(struct strbuf *sb, int fd); /** * Read a line from a FILE *, overwriting the existing contents of -- cgit v1.2.1