From c71d8bb38a73abc910a63bf7a81f3869dc9c2f34 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Mon, 9 Apr 2018 10:32:29 +0200 Subject: git_config_set: reuse empty sections It can happen quite easily that the last setting in a config section is removed, and to avoid confusion when there are comments in the config about that section, we keep a lone section header, i.e. an empty section. Now that we use the `event_fn` callback, it is easy to add support for re-using empty sections, so let's do that. Note: t5512-ls-remote requires that this change is applied *after* the patch "git config --unset: remove empty sections (in the common case)": without that patch, there would be empty `transfer` and `uploadpack` sections ready for reuse, but in the *wrong* order (and sconsequently, t5512's "overrides work between mixed transfer/upload-pack hideRefs" would fail). Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- t/t1300-config.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 't/t1300-config.sh') diff --git a/t/t1300-config.sh b/t/t1300-config.sh index 92aaa53794..e43982a9c1 100755 --- a/t/t1300-config.sh +++ b/t/t1300-config.sh @@ -1483,7 +1483,7 @@ test_expect_success '--unset-all removes section if empty & uncommented' ' test_line_count = 0 .git/config ' -test_expect_failure 'adding a key into an empty section reuses header' ' +test_expect_success 'adding a key into an empty section reuses header' ' cat >.git/config <<-\EOF && [section] EOF -- cgit v1.2.1