From daa22c6f8da466bd7a438f1bc27375fd737ffcf3 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Tue, 6 May 2014 00:17:14 +0000 Subject: config: preserve config file permissions on edits Users may already store sensitive data such as imap.pass in .git/config; making the file world-readable when "git config" is called to edit means their password would be compromised on a shared system. [v2: updated for section renames, as noted by Junio] Signed-off-by: Eric Wong Signed-off-by: Junio C Hamano --- t/t1300-repo-config.sh | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 't/t1300-repo-config.sh') diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh index 967359344d..ba41bc93ee 100755 --- a/t/t1300-repo-config.sh +++ b/t/t1300-repo-config.sh @@ -1154,4 +1154,14 @@ test_expect_failure 'adding a key into an empty section reuses header' ' test_cmp expect .git/config ' +test_expect_success POSIXPERM,PERL 'preserves existing permissions' ' + chmod 0600 .git/config && + git config imap.pass Hunter2 && + perl -e \ + "die q(badset) if ((stat(q(.git/config)))[2] & 07777) != 0600" && + git config --rename-section imap pop && + perl -e \ + "die q(badrename) if ((stat(q(.git/config)))[2] & 07777) != 0600" +' + test_done -- cgit v1.2.1