delta/gitlab/gitlab-ce.git, branch services_refactoring1

Services: code style fixes, minor refactoring

2016-07-06T17:58:43+00:00

Merge branch 'allow-disabling-of-git-access-protocol' into 'master'

2016-07-05T22:57:19+00:00


Add setting that allows admins to choose which Git access protocols are enabled.

## What does this MR do?

It allows admins to disable one of the two protocols for Git access. They can choose to enable just SSH, HTTP or allow both. If one of them is disabled, the clone URL in the project will show only the allowed protocol, and no dropdown to change protocols will be presented.

## What are the relevant issue numbers?

Full implementation on GitLab's side for #18601 

GitLab Shell implementation: gitlab-org/gitlab-shell!62

GitLab Workhorse implementation: gitlab-org/gitlab-workhorse!51

## Screenshots (if relevant)

![Screen_Shot_2016-06-16_at_12.26.19_PM](/uploads/bad845142e9704a7385b2eaca51fd4eb/Screen_Shot_2016-06-16_at_12.26.19_PM.png)
![Screen_Shot_2016-06-20_at_4.24.54_PM](/uploads/6e452dd269e06f0be23841ce93866ed6/Screen_Shot_2016-06-20_at_4.24.54_PM.png)



/cc @jschatz1  this MR touches the UI. Please review.

See merge request !4696

Use keyword arguments for boolean values and use `span` instead of `a` for clone "button"

2016-07-05T21:54:22+00:00

Revert back to not defining a default Git access protocol.

2016-07-05T21:54:22+00:00

Rebasing caused `enabled_git_access_protocol` to become plural. Fixed here.

2016-07-05T21:54:22+00:00

Clone button should not be clickable when there is a disabled protocol

2016-07-05T21:54:22+00:00

Default Git access protocol to `web`

2016-07-05T21:54:22+00:00

Rename `enabled_git_access_protocols` to singular.

2016-07-05T21:54:22+00:00

Add `alt` text to the images in the documentation.

2016-07-05T21:54:22+00:00

Don't allow empty strings in the `protocol` check.

2016-07-05T21:54:22+00:00