delta/gitlab/gitlab-ce.git, branch subscribe-button-fix

Fixed style issues

2016-04-14T13:06:33+00:00

Fixed haml style issues

2016-04-14T08:13:32+00:00

Fixed issue with failing tests

2016-04-12T14:54:26+00:00

Removed references to subscribe-button CSS class

2016-04-12T12:35:06+00:00

These were being blocked by adblocks

Closes #15043

Merge branch 'dashboard-filter-milestone' into 'master'

2016-04-11T13:56:29+00:00


Fixed issue with dashboard/issues not filtering by milestone

Closes #15128

See merge request !3650

Merge branch 'complexity/descrease-abc-size-threshold' into 'master'

2016-04-11T13:45:37+00:00


Decrease threshold for ABC Size metric in Rubocop

To 55.

References #3444

See merge request !3598

Merge branch 'metrics-measure-block-transaction' into 'master'

2016-04-11T13:16:58+00:00


Store block timings as transaction values

See merge request !3649

Fixed stubbing for Gitlab::Metrics specs

2016-04-11T12:29:38+00:00

If the measure method uses Transaction.current directly the SQL
subscriber (Subscribers::ActiveRecord) will add timings of queries
triggered by DB cleaner.

Merge branch 'rs-form_errors' into 'master'

2016-04-11T12:01:50+00:00


Standardize the way we check for and display form errors

- Some views had a "Close" button. We've removed this, because we don't
  want users accidentally hiding the validation errors and not knowing
  what needs to be fixed.
- Some views used `li`, some used `p`, some used `span`. We've
  standardized on `li`.
- Some views only showed the first error. We've standardized on showing
  all of them.
- Some views added an `#error_explanation` div, which we've made
  standard.

See merge request !3531

Merge branch 'rs-code-review-guide' into 'master'

2016-04-11T11:28:42+00:00


First pass at a Code Review guide

Largely borrowed from thoughtbot's code review guide, so attribution is
included.

[ci skip]

See merge request !3639