Fix redirect after update file when user has forked project

2016-12-29T23:11:34+00:00

Merge branch 'jej-23867-use-mr-finder-instead-of-access-check' into 'security'

2016-12-09T00:42:07+00:00

Replace MR access checks with use of MergeRequestsFinder

Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867

:warning: - Potentially untested
:bomb: - No test coverage
:traffic_light: - Test coverage of some sort exists (a test failed when error raised)
:vertical_traffic_light: - Test coverage of return value (a test failed when nil used)
:white_check_mark: - Permissions check tested

- [x] :bomb:  app/finders/notes_finder.rb:17
- [x] :warning:  app/views/layouts/nav/_project.html.haml:80 [`.count`]
- [x] :bomb:  app/controllers/concerns/creates_commit.rb:84
- [x] :traffic_light:  app/controllers/projects/commits_controller.rb:24
- [x] :traffic_light:  app/controllers/projects/compare_controller.rb:56
- [x] :vertical_traffic_light:  app/controllers/projects/discussions_controller.rb:29
- [x] :white_check_mark:  app/controllers/projects/todos_controller.rb:27
- [x] :vertical_traffic_light:  app/models/commit.rb:268
- [x] :white_check_mark: lib/gitlab/search_results.rb:71

- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)`
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`.
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use  of unchecked `merged_merge_request?`

See merge request !2033

fixes distinction between renaming a file and updating its content and

2016-09-10T03:05:30+00:00

refactors update file

refactors update action to change commit_params with the correct path

2016-07-12T14:55:16+00:00

changes the usasge of path to file_path on blob_controller for compatibillity with the create action

2016-07-12T14:55:16+00:00

removes debugging prints from code

2016-07-12T14:53:25+00:00

refactors blob_controller

2016-07-12T14:52:47+00:00

removes debugging prints from code

2016-07-12T14:49:47+00:00

refactors blob_controller

2016-07-12T14:49:21+00:00

removes debugging prints from code

2016-07-12T14:41:20+00:00

delta/gitlab/gitlab-ce.git/app/controllers/concerns/creates_commit.rb, branch fix/serialized-commit-path

Fix redirect after update file when user has forked project

Merge branch 'jej-23867-use-mr-finder-instead-of-access-check' into 'security'

fixes distinction between renaming a file and updating its content and

refactors update action to change commit_params with the correct path

changes the usasge of path to file_path on blob_controller for compatibillity with the create action

removes debugging prints from code

refactors blob_controller

removes debugging prints from code

refactors blob_controller

removes debugging prints from code