<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/models/ci, branch docs-pages-https</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Replace : with _ in cache key versioning</title>
<updated>2018-01-26T18:15:38+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2018-01-26T18:15:38+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ca05c3a9b6a000bb468fac7b61ff08ba51681b57'/>
<id>ca05c3a9b6a000bb468fac7b61ff08ba51681b57</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Look for rugged with static analysis</title>
<updated>2018-01-25T13:05:11+00:00</updated>
<author>
<name>Jacob Vosmaer</name>
<email>jacob@gitlab.com</email>
</author>
<published>2018-01-23T17:42:10+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6d6f7536bd9b5bcbf94dfbe15cc86e84d06527f5'/>
<id>6d6f7536bd9b5bcbf94dfbe15cc86e84d06527f5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Ensure CI pipelines and builds have the correction project associations</title>
<updated>2018-01-14T16:11:51+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2018-01-14T07:18:50+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8ddb00adbf73ede641bfa93388e18591c03e6668'/>
<id>8ddb00adbf73ede641bfa93388e18591c03e6668</id>
<content type='text'>
This should reduce the number of SQL queries and lookups needed to look up a
project of a build and pipeline and vice versa.

Before:

```
[1] pry(main)&gt; Ci::Build.reflect_on_association(:project).has_inverse?
=&gt; false
[2] pry(main)&gt; Project.reflect_on_association(:builds).has_inverse?
=&gt; false
[3] pry(main)&gt; Ci::Pipeline.reflect_on_association(:project).has_inverse?
=&gt; false
[4] pry(main)&gt; Project.reflect_on_association(:pipelines).has_inverse?
=&gt; :project
```

After:

```
[1] pry(main)&gt; Ci::Build.reflect_on_association(:project).has_inverse?
=&gt; :builds
[2] pry(main)&gt; Project.reflect_on_association(:builds).has_inverse?
=&gt; :project
[3] pry(main)&gt; Ci::Pipeline.reflect_on_association(:project).has_inverse?
=&gt; :pipelines
[4] pry(main)&gt; Project.reflect_on_association(:pipelines).has_inverse?
=&gt; :project
```
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This should reduce the number of SQL queries and lookups needed to look up a
project of a build and pipeline and vice versa.

Before:

```
[1] pry(main)&gt; Ci::Build.reflect_on_association(:project).has_inverse?
=&gt; false
[2] pry(main)&gt; Project.reflect_on_association(:builds).has_inverse?
=&gt; false
[3] pry(main)&gt; Ci::Pipeline.reflect_on_association(:project).has_inverse?
=&gt; false
[4] pry(main)&gt; Project.reflect_on_association(:pipelines).has_inverse?
=&gt; :project
```

After:

```
[1] pry(main)&gt; Ci::Build.reflect_on_association(:project).has_inverse?
=&gt; :builds
[2] pry(main)&gt; Project.reflect_on_association(:builds).has_inverse?
=&gt; :project
[3] pry(main)&gt; Ci::Pipeline.reflect_on_association(:project).has_inverse?
=&gt; :pipelines
[4] pry(main)&gt; Project.reflect_on_association(:pipelines).has_inverse?
=&gt; :project
```
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove soft removals related code</title>
<updated>2018-01-08T16:04:45+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2018-01-02T16:21:28+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d0b8f536a1865af3741fc3255325b7e211ed1d42'/>
<id>d0b8f536a1865af3741fc3255325b7e211ed1d42</id>
<content type='text'>
This removes all usage of soft removals except for the "pending delete"
system implemented for projects. This in turn simplifies all the query
plans of the models that used soft removals. Since we don't really use
soft removals for anything useful there's no point in keeping it around.

This _does_ mean that hard removals of issues (which only admins can do
if I'm not mistaken) can influence the "iid" values, but that code is
broken to begin with. More on this (and how to fix it) can be found in
https://gitlab.com/gitlab-org/gitlab-ce/issues/31114.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37447
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This removes all usage of soft removals except for the "pending delete"
system implemented for projects. This in turn simplifies all the query
plans of the models that used soft removals. Since we don't really use
soft removals for anything useful there's no point in keeping it around.

This _does_ mean that hard removals of issues (which only admins can do
if I'm not mistaken) can influence the "iid" values, but that code is
broken to begin with. More on this (and how to fix it) can be found in
https://gitlab.com/gitlab-org/gitlab-ce/issues/31114.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37447
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix/gb/fix-import-export-restoring-associations' into 'master'</title>
<updated>2018-01-07T16:02:40+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2018-01-07T16:02:40+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=df48758c69e5927a45fb70293c18a2ec82995d6c'/>
<id>df48758c69e5927a45fb70293c18a2ec82995d6c</id>
<content type='text'>
Fix restoring associations with import/export

Closes #41646

See merge request gitlab-org/gitlab-ce!16221</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix restoring associations with import/export

Closes #41646

See merge request gitlab-org/gitlab-ce!16221</pre>
</div>
</content>
</entry>
<entry>
<title>Assign stage and pipeline to a status when importing</title>
<updated>2018-01-05T13:48:50+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzesiek.bizon@gmail.com</email>
</author>
<published>2018-01-05T13:48:50+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=05ddb259958c27506cb075342fae5a70cf8ce257'/>
<id>05ddb259958c27506cb075342fae5a70cf8ce257</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor Ci::Build#cache</title>
<updated>2018-01-04T21:17:03+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2018-01-04T18:43:31+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2682966829b49b7fbeee02e5c070c8c14630ea6a'/>
<id>2682966829b49b7fbeee02e5c070c8c14630ea6a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename Project#cache_index to jobs_cache_index</title>
<updated>2018-01-04T21:17:03+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2018-01-04T18:40:07+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8cc14dd5371c33f389211fcee39dbb28686b2021'/>
<id>8cc14dd5371c33f389211fcee39dbb28686b2021</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Use Project.cache_index in Build#cache</title>
<updated>2017-12-22T22:06:15+00:00</updated>
<author>
<name>Matija Čupić</name>
<email>matteeyah@gmail.com</email>
</author>
<published>2017-12-22T22:06:15+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=771b97394a16ae8dcd9acc84ab6a076f68726fd9'/>
<id>771b97394a16ae8dcd9acc84ab6a076f68726fd9</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Load commit in batches for pipelines#index</title>
<updated>2017-12-19T09:05:40+00:00</updated>
<author>
<name>Zeger-Jan van de Weg</name>
<email>git@zjvandeweg.nl</email>
</author>
<published>2017-12-05T13:15:30+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c6edae38870a4228e3b964d647b9ef588df11f27'/>
<id>c6edae38870a4228e3b964d647b9ef588df11f27</id>
<content type='text'>
Uses `list_commits_by_oid` on the CommitService, to request the needed
commits for pipelines. These commits are needed to display the user that
created the commit and the commit title.

This includes fixes for tests failing that depended on the commit
being `nil`. However, now these are batch loaded, this doesn't happen
anymore and the commits are an instance of BatchLoader.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Uses `list_commits_by_oid` on the CommitService, to request the needed
commits for pipelines. These commits are needed to display the user that
created the commit and the commit title.

This includes fixes for tests failing that depended on the commit
being `nil`. However, now these are batch loaded, this doesn't happen
anymore and the commits are an instance of BatchLoader.
</pre>
</div>
</content>
</entry>
</feed>
