delta/gitlab/gitlab-ce.git/app/models/commit.rb, branch fix/serialized-commit-path gitlab.com: gitlab-org/gitlab-ce.git Fix cross-project references copy to include the project reference 2017-01-03T12:01:46+00:00 James Lopez james@jameslopez.es 2016-12-21T16:41:33+00:00 112f47057275312daa876bee5bd74d5464410bc5 Also added relevant specs and refactored to_references in a bunch of places to be more consistent. 
Also added relevant specs and refactored to_references in a bunch of places to be more consistent.
Introduce latest_status and add a few tests 2016-12-14T15:37:49+00:00 Lin Jen-Shin godfat@godfat.org 2016-12-14T13:00:06+00:00 7cced60069c248156decf6ceabc4d1f447e47ff7 Feedback: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20003268 
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20003268
Merge remote-tracking branch 'upstream/master' into show-commit-status-from-latest-pipeline 2016-12-14T11:24:31+00:00 Lin Jen-Shin godfat@godfat.org 2016-12-14T11:24:31+00:00 367024f1707ebbf986e5f25ac208f24e35746389 * upstream/master: (557 commits) Fix wrong error message expectation in API::Commits spec Move admin settings spinach feature to rspec Encode when migrating ProcessCommitWorker jobs Prevent overflow with vertical scroll when we have space to show content Make rubocop happy API: Ability to cherry-pick a commit Be smarter when finding a sudoed user in API::Helpers Backport hooks on group policies for the EE-specific implementation API: Ability to get group's project in simple representation Add AddLowerPathIndexToRoutes to setup_postgresql.rake For single line git commit messages, the close quote should be on the same line as the open quote added border-radius and padding to labels Allow all alphanumeric characters in file names (!8002) Add failing test for #20190 Don't allow blank MR titles in API Replace static fixture for awards_handler_spec (!7661) Crontab typo '* */6' -> '0 */6' (4x/day not 1x-per-min-for-1h 4x/day) Fix test Tweak style and add back wording Clean up commit copy to clipboard and make consistent ... 
* upstream/master: (557 commits)
  Fix wrong error message expectation in API::Commits spec
  Move admin settings spinach feature to rspec
  Encode when migrating ProcessCommitWorker jobs
  Prevent overflow with vertical scroll when we have space to show content
  Make rubocop happy
  API: Ability to cherry-pick a commit
  Be smarter when finding a sudoed user in API::Helpers
  Backport hooks on group policies for the EE-specific implementation
  API: Ability to get group's project in simple representation
  Add AddLowerPathIndexToRoutes to setup_postgresql.rake
  For single line git commit messages, the close quote should be on the same line as the open quote
  added border-radius and padding to labels
  Allow all alphanumeric characters in file names (!8002)
  Add failing test for #20190
  Don't allow blank MR titles in API
  Replace static fixture for awards_handler_spec (!7661)
  Crontab typo '* */6' -> '0 */6' (4x/day not 1x-per-min-for-1h 4x/day)
  Fix test
  Tweak style and add back wording
  Clean up commit copy to clipboard and make consistent
  ...
Merge branch 'jej-23867-use-mr-finder-instead-of-access-check' into 'security' 2016-12-09T00:42:07+00:00 Douwe Maan douwe@gitlab.com 2016-11-29T13:47:43+00:00 f23b1cb453deea2659c0cb9e9047c72d859bbf9d Replace MR access checks with use of MergeRequestsFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 :warning: - Potentially untested :bomb: - No test coverage :traffic_light: - Test coverage of some sort exists (a test failed when error raised) :vertical_traffic_light: - Test coverage of return value (a test failed when nil used) :white_check_mark: - Permissions check tested - [x] :bomb: app/finders/notes_finder.rb:17 - [x] :warning: app/views/layouts/nav/_project.html.haml:80 [`.count`] - [x] :bomb: app/controllers/concerns/creates_commit.rb:84 - [x] :traffic_light: app/controllers/projects/commits_controller.rb:24 - [x] :traffic_light: app/controllers/projects/compare_controller.rb:56 - [x] :vertical_traffic_light: app/controllers/projects/discussions_controller.rb:29 - [x] :white_check_mark: app/controllers/projects/todos_controller.rb:27 - [x] :vertical_traffic_light: app/models/commit.rb:268 - [x] :white_check_mark: lib/gitlab/search_results.rb:71 - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)` - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`. - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use of unchecked `merged_merge_request?` See merge request !2033 
Replace MR access checks with use of MergeRequestsFinder

Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867

:warning: - Potentially untested
:bomb: - No test coverage
:traffic_light: - Test coverage of some sort exists (a test failed when error raised)
:vertical_traffic_light: - Test coverage of return value (a test failed when nil used)
:white_check_mark: - Permissions check tested

- [x] :bomb:  app/finders/notes_finder.rb:17
- [x] :warning:  app/views/layouts/nav/_project.html.haml:80 [`.count`]
- [x] :bomb:  app/controllers/concerns/creates_commit.rb:84
- [x] :traffic_light:  app/controllers/projects/commits_controller.rb:24
- [x] :traffic_light:  app/controllers/projects/compare_controller.rb:56
- [x] :vertical_traffic_light:  app/controllers/projects/discussions_controller.rb:29
- [x] :white_check_mark:  app/controllers/projects/todos_controller.rb:27
- [x] :vertical_traffic_light:  app/models/commit.rb:268
- [x] :white_check_mark: lib/gitlab/search_results.rb:71

- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)`
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`.
- [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use  of unchecked `merged_merge_request?`

See merge request !2033
Add shorthand support to gitlab markdown references 2016-12-02T21:18:17+00:00 Oswaldo Ferreira oswluizf@gmail.com 2016-11-02T23:49:13+00:00 f272ee6eba37548cbd8919139d583a71ffdac8dc 






Pass commit data to ProcessCommitWorker
2016-12-01T12:36:06+00:00

Yorick Peterse
yorickpeterse@gmail.com

2016-11-24T14:07:44+00:00

6b4d33566f5f434cc86381a4a1347e42bbe348ee

By passing commit data to this worker we remove the need for querying
the Git repository for every job. This in turn reduces the time spent
processing each job.

The migration included migrates jobs from the old format to the new
format. For this to work properly it requires downtime as otherwise
workers may start producing errors until they're using a newer version
of the worker code.





By passing commit data to this worker we remove the need for querying
the Git repository for every job. This in turn reduces the time spent
processing each job.

The migration included migrates jobs from the old format to the new
format. For this to work properly it requires downtime as otherwise
workers may start producing errors until they're using a newer version
of the worker code.







Rename latest_for to latest, feedback:
2016-11-24T08:50:37+00:00

Lin Jen-Shin
godfat@godfat.org

2016-11-24T08:50:37+00:00

6192ea53fad0ea04e356e5a79a5a0e5359ba46ce

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333/diffs#note_18819292





https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333/diffs#note_18819292







Still use compound pipeline status, but group by
2016-11-21T14:19:16+00:00

Lin Jen-Shin
godfat@godfat.org

2016-11-21T14:19:16+00:00

721f2d3788ae5e8374f357014bd9e20d62de0a81

ref and sha so that it would show latest pipeline
if ref and sha are both specified, otherwise still
the same as before.





ref and sha so that it would show latest pipeline
if ref and sha are both specified, otherwise still
the same as before.







Show commit status from latest pipeline
2016-11-07T16:04:18+00:00

Lin Jen-Shin
godfat@godfat.org

2016-11-07T15:44:11+00:00

18a71c47603d703de73c46fef4889887f685bebe

Rather than compound status from all pipelines.

Closes #20560





Rather than compound status from all pipelines.

Closes #20560







Initialize @statuses in status rather than constructor
2016-11-03T15:43:17+00:00

Lin Jen-Shin
godfat@godfat.org

2016-11-03T15:43:17+00:00

0902ba524f6bfa7f7f6d234378c8847b541d1586

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7034#note_17742312





Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7034#note_17742312