<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/models, branch parallel-tests</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Merge branch 'projects-finder-ee-compatible' into 'master'</title>
<updated>2016-03-12T16:50:51+00:00</updated>
<author>
<name>Dmitriy Zaporozhets</name>
<email>dmitriy.zaporozhets@gmail.com</email>
</author>
<published>2016-03-12T16:50:51+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a3b626bf2544a1ad98651a2a2c5cdd13dc934e12'/>
<id>a3b626bf2544a1ad98651a2a2c5cdd13dc934e12</id>
<content type='text'>

Removed User#project_relations

This is to make things more compatible with EE so merging is easier.

cc @dzaporozhets 

See merge request !3192</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Removed User#project_relations

This is to make things more compatible with EE so merging is easier.

cc @dzaporozhets 

See merge request !3192</pre>
</div>
</content>
</entry>
<entry>
<title>Removed User#project_relations</title>
<updated>2016-03-12T14:44:48+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-03-12T14:44:48+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3b76b73ab178f0504e2a9be934fb13f239c81857'/>
<id>3b76b73ab178f0504e2a9be934fb13f239c81857</id>
<content type='text'>
GitLab EE adds an extra relation that selects a "project_id" column
instead of an "id" column, making it very hard for this method to be
re-used in EE. Since using User#authorized_groups in
ProjectsFinder#all_groups apparently has no performance impact we can
just use it and keep everything compatible with EE.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
GitLab EE adds an extra relation that selects a "project_id" column
instead of an "id" column, making it very hard for this method to be
re-used in EE. Since using User#authorized_groups in
ProjectsFinder#all_groups apparently has no performance impact we can
just use it and keep everything compatible with EE.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'rs-disallow-blank-line-code' into 'master'</title>
<updated>2016-03-12T14:01:06+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2016-03-12T14:01:06+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8ee1c0ffe538f1b0a4eecf859c3e79724ffae5ef'/>
<id>8ee1c0ffe538f1b0a4eecf859c3e79724ffae5ef</id>
<content type='text'>

Disallow blank (non-null) values for a Note's `line_code` attribute

It's unclear how these blank values got added, but GitLab.com had a few:

```
irb(main):002:0&gt; Note.where("line_code IS NOT NULL AND line_code = ''").count
=&gt; 439
```

We've added a migration to convert any existing records to use a NULL
value when blank, and updated Note to set blank values to nil before
validation.

See merge request !3118</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Disallow blank (non-null) values for a Note's `line_code` attribute

It's unclear how these blank values got added, but GitLab.com had a few:

```
irb(main):002:0&gt; Note.where("line_code IS NOT NULL AND line_code = ''").count
=&gt; 439
```

We've added a migration to convert any existing records to use a NULL
value when blank, and updated Note to set blank values to nil before
validation.

See merge request !3118</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'fix/token-timing-attack' into 'master'</title>
<updated>2016-03-12T12:14:32+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2016-03-12T12:14:32+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=34e8c562363a130ca9f2a6be7959efbc54e64663'/>
<id>34e8c562363a130ca9f2a6be7959efbc54e64663</id>
<content type='text'>

fix token issue - timing attack

Updates token comparisons to use a secure version instead of `==`

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/13617

See merge request !3062</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

fix token issue - timing attack

Updates token comparisons to use a secure version instead of `==`

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/13617

See merge request !3062</pre>
</div>
</content>
</entry>
<entry>
<title>Disallow blank (non-null) values for a Note's `line_code` attribute</title>
<updated>2016-03-11T22:46:50+00:00</updated>
<author>
<name>Robert Speicher</name>
<email>rspeicher@gmail.com</email>
</author>
<published>2016-03-11T22:46:50+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=01f6db4f643380d143772958b22d3f318b1db3a7'/>
<id>01f6db4f643380d143772958b22d3f318b1db3a7</id>
<content type='text'>
It's unclear how these blank values got added, but GitLab.com had a few:

```
irb(main):002:0&gt; Note.where("line_code IS NOT NULL AND line_code = ''").count
=&gt; 439
```

We've added a migration to convert any existing records to use a NULL
value when blank, and updated Note to set blank values to nil before
validation.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It's unclear how these blank values got added, but GitLab.com had a few:

```
irb(main):002:0&gt; Note.where("line_code IS NOT NULL AND line_code = ''").count
=&gt; 439
```

We've added a migration to convert any existing records to use a NULL
value when blank, and updated Note to set blank values to nil before
validation.
</pre>
</div>
</content>
</entry>
<entry>
<title>Use a UNION in MergeRequest.in_projects</title>
<updated>2016-03-11T20:26:32+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-03-07T11:56:46+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=4f3fa519c627b7caf45273226ae438181dfbc392'/>
<id>4f3fa519c627b7caf45273226ae438181dfbc392</id>
<content type='text'>
The OR condition for source_project_id/target_project_id leads to a
query plan that performs rather poorly on PostgreSQL due to the use of
sub-queries. Because Rails offers no easy alternative for this
particular problem we're forced to using a UNION for both conditions.
The resulting query performs much faster than just using an OR.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The OR condition for source_project_id/target_project_id leads to a
query plan that performs rather poorly on PostgreSQL due to the use of
sub-queries. Because Rails offers no easy alternative for this
particular problem we're forced to using a UNION for both conditions.
The resulting query performs much faster than just using an OR.
</pre>
</div>
</content>
</entry>
<entry>
<title>Make Namespace.search case-insensitive</title>
<updated>2016-03-11T20:25:24+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-03-04T11:06:25+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ee75c49313127f53fe60a0701f40024b897a15e8'/>
<id>ee75c49313127f53fe60a0701f40024b897a15e8</id>
<content type='text'>
This ensures searching namespaces works exactly the same as searching
for any other resource.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This ensures searching namespaces works exactly the same as searching
for any other resource.
</pre>
</div>
</content>
</entry>
<entry>
<title>Removed arel_table receiver from search methods</title>
<updated>2016-03-11T20:25:23+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-03-04T11:01:21+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d7d5937531350283f6cbd68dead5750227e6d962'/>
<id>d7d5937531350283f6cbd68dead5750227e6d962</id>
<content type='text'>
We can just use "arel_table" in these cases instead of
"SomeClass.arel_table".
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We can just use "arel_table" in these cases instead of
"SomeClass.arel_table".
</pre>
</div>
</content>
</entry>
<entry>
<title>Clean up ProjectsFinder for getting user projects</title>
<updated>2016-03-11T20:25:23+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-03-04T10:39:00+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=9e00a237161679b0d6afdefd246e0a7bf209510c'/>
<id>9e00a237161679b0d6afdefd246e0a7bf209510c</id>
<content type='text'>
We don't need the extra layer of nesting of UNION queries here (as
User#authorized_projects already returns a UNION'd query).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We don't need the extra layer of nesting of UNION queries here (as
User#authorized_projects already returns a UNION'd query).
</pre>
</div>
</content>
</entry>
<entry>
<title>Use ILIKE/LIKE for searching milestones</title>
<updated>2016-03-11T20:25:22+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2016-03-01T16:05:26+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2cf7f3f410832560bf049b24fbcaa27c1e3f30c7'/>
<id>2cf7f3f410832560bf049b24fbcaa27c1e3f30c7</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
