delta/gitlab/gitlab-ce.git/app/models, branch rendering-markdown-multiple-projects gitlab.com: gitlab-org/gitlab-ce.git Verify that deploy token has valid access when pulling container registry image 2018-04-10T07:31:30+00:00 Mayra Cabrera mcabrera@gitlab.com 2018-04-10T07:31:30+00:00 3e35f65394fad201a9277667772f3ad9c6940d07 






Merge branch 'fix-n-plus-one-when-getting-notification-settings-for-recipients' into 'master'
2018-04-09T15:36:56+00:00

Yorick Peterse
yorickpeterse@gmail.com

2018-04-09T15:36:56+00:00

db204e23fc5a1bf161e7475fe06199fb435e1cab

Use Goldiloader for handling N+1 queries

See merge request gitlab-org/gitlab-ce!18217




Use Goldiloader for handling N+1 queries

See merge request gitlab-org/gitlab-ce!18217






Add cop for has_many :through without disabled autoloading
2018-04-09T11:47:04+00:00

Sean McGivern
sean@gitlab.com

2018-04-09T11:19:18+00:00

4ef3e3491e2ecc34e7f4de1221d5ad7b8b4a1e24

Goldiloader is great, but has several issues with has_many :through relations:

* https://github.com/salsify/goldiloader/issues/12
* https://github.com/salsify/goldiloader/issues/14
* https://github.com/salsify/goldiloader/issues/18

Rather than try to figure out which applies in each case, we should just do the
drudge work of manually disabling autoloading for all relations of this type. We
can always use regular preloading for specific cases, but this way we avoid
generating invalid queries through Goldiloader's magic.





Goldiloader is great, but has several issues with has_many :through relations:

* https://github.com/salsify/goldiloader/issues/12
* https://github.com/salsify/goldiloader/issues/14
* https://github.com/salsify/goldiloader/issues/18

Rather than try to figure out which applies in each case, we should just do the
drudge work of manually disabling autoloading for all relations of this type. We
can always use regular preloading for specific cases, but this way we avoid
generating invalid queries through Goldiloader's magic.







Use Goldiloader for handling N+1 queries
2018-04-09T10:58:06+00:00

Yorick Peterse
yorickpeterse@gmail.com

2018-04-05T11:19:24+00:00

20fdbbe86a6cffbf467f08d50a0d8ef0f5c87f50

Goldiloader (https://github.com/salsify/goldiloader) can eager load
associations automatically. This removes the need for adding "includes"
calls in a variety of different places. This also comes with the added
benefit of not having to eager load data if it's not used.





Goldiloader (https://github.com/salsify/goldiloader) can eager load
associations automatically. This removes the need for adding "includes"
calls in a variety of different places. This also comes with the added
benefit of not having to eager load data if it's not used.







Merge branch '41981-allow-group-owner-to-enable-runners-from-subgroups' into 'master'
2018-04-09T10:21:01+00:00

Yorick Peterse
yorickpeterse@gmail.com

2018-04-09T10:21:01+00:00

f22df3e9c1c590874cea8d50ab10f28467baaf18

Resolve "Group owner cannot enable/disable specific-runners which was registered in a project under a subgroup"

Closes #41981

See merge request gitlab-org/gitlab-ce!18009




Resolve "Group owner cannot enable/disable specific-runners which was registered in a project under a subgroup"

Closes #41981

See merge request gitlab-org/gitlab-ce!18009






Merge branch 'blackst0ne-rails5-replace-true-values-with-false-values' into 'master'
2018-04-09T07:57:37+00:00

Sean McGivern
sean@mcgivern.me.uk

2018-04-09T07:57:37+00:00

1917d53b2282d28eff43b550d8e38ba2be075b77

[Rails5] Add FALSE_VALUES constant to Service#boolean_accessor

See merge request gitlab-org/gitlab-ce!18240




[Rails5] Add FALSE_VALUES constant to Service#boolean_accessor

See merge request gitlab-org/gitlab-ce!18240






Remove unused User#manageable_group_projects (#41981)
2018-04-09T00:46:42+00:00

Dylan Griffith
dyl.griffith@gmail.com

2018-04-06T21:31:52+00:00

f45b8888fc1a2694b8e2da64512137ab54a09a66












Use project_authorizations instead of members to calculate manageable CI projects to speed up query (#41981)
2018-04-09T00:46:42+00:00

Dylan Griffith
dyl.griffith@gmail.com

2018-04-05T03:12:21+00:00

742d23a5d0f61c9939d42605762b6fc073ae4f22












Allow group owner to enable runners from subgroups (#41981)
2018-04-09T00:46:42+00:00

Dylan Griffith
dyl.griffith@gmail.com

2018-03-27T05:31:43+00:00

0e78c2e9c925d180a443d132658691adf18f26a1












[Rails5] Add FALSE_VALUES constant to Service#boolean_accessor
2018-04-07T22:48:38+00:00

blackst0ne
blackst0ne.ru@gmail.com

2018-04-07T22:48:38+00:00

432e57fccfcc854f8aedc578111c1d4a6b0f4a2d

In Rails 5.0 the `ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES`
constant has been removed [1] and the remaining `FALSE_VALUES` constant
has been moved to `ActiveModel::Type::Boolean` [2]

[1]: https://github.com/rails/rails/commit/a502703c3d2151d4d3b421b29fefdac5ad05df61
[2]: https://github.com/rails/rails/commit/9cc8c6f3730df3d94c81a55be9ee1b7b4ffd29f6





In Rails 5.0 the `ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES`
constant has been removed [1] and the remaining `FALSE_VALUES` constant
has been moved to `ActiveModel::Type::Boolean` [2]

[1]: https://github.com/rails/rails/commit/a502703c3d2151d4d3b421b29fefdac5ad05df61
[2]: https://github.com/rails/rails/commit/9cc8c6f3730df3d94c81a55be9ee1b7b4ffd29f6