<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/presenters, branch docs/edit-feature-flags</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Replace ... with new expansion options</title>
<updated>2019-08-10T02:36:32+00:00</updated>
<author>
<name>Samantha Ming</name>
<email>sming@gitlab.com</email>
</author>
<published>2019-08-10T02:36:32+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=fc0ff7cf033e6267d7348057faee0fbedf5b90e8'/>
<id>fc0ff7cf033e6267d7348057faee0fbedf5b90e8</id>
<content type='text'>
- expand upwards
- expand downwards
- expand all

in both inline and parallel views
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- expand upwards
- expand downwards
- expand all

in both inline and parallel views
</pre>
</div>
</content>
</entry>
<entry>
<title>Split MR widget into cached and non-cached serializers</title>
<updated>2019-08-09T21:01:55+00:00</updated>
<author>
<name>Igor</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2019-08-09T21:01:55+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b99011af62935de0b15e8a314ffb7df1f8a3f303'/>
<id>b99011af62935de0b15e8a314ffb7df1f8a3f303</id>
<content type='text'>
Splits auto-refreshing of MR widget into 2 requests:

- the one which uses etag-caching and invalidates the fields on change
- the one without caching

The idea is to gradually move all the fields to etag-cached endpoint
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Splits auto-refreshing of MR widget into 2 requests:

- the one which uses etag-caching and invalidates the fields on change
- the one without caching

The idea is to gradually move all the fields to etag-cached endpoint
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "Merge branch '65152-selective-highlight' into 'master'"</title>
<updated>2019-08-09T00:13:09+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-08-09T00:13:09+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=6d318af5f95cc4091b09f1b2f8ed9981f3a8b9c7'/>
<id>6d318af5f95cc4091b09f1b2f8ed9981f3a8b9c7</id>
<content type='text'>
This reverts merge request !31361</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts merge request !31361</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '65152-selective-highlight' into 'master'</title>
<updated>2019-08-06T16:42:14+00:00</updated>
<author>
<name>Bob Van Landuyt</name>
<email>bob@gitlab.com</email>
</author>
<published>2019-08-06T16:42:14+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d61dab914756854c0f5bef50306be77212ee15b4'/>
<id>d61dab914756854c0f5bef50306be77212ee15b4</id>
<content type='text'>
Support selective highlighting of lines

See merge request gitlab-org/gitlab-ce!31361</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Support selective highlighting of lines

See merge request gitlab-org/gitlab-ce!31361</pre>
</div>
</content>
</entry>
<entry>
<title>Support selective highlighting of lines</title>
<updated>2019-08-06T01:32:29+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-08-05T09:44:13+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=46631e102366bd40bdb449b87fae3f10e992ee68'/>
<id>46631e102366bd40bdb449b87fae3f10e992ee68</id>
<content type='text'>
Instead of highlighting all lines when not all of them are
needed, only highlight specific lines.

The `BlobPresenter#highlight` method has been updated to
support `since` and `to` params. These params will be used to
limit the content to be highlighted.

Modify `Gitlab::Highlight` to support `since` param which will
then be used to determine the starting line number.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of highlighting all lines when not all of them are
needed, only highlight specific lines.

The `BlobPresenter#highlight` method has been updated to
support `since` and `to` params. These params will be used to
limit the content to be highlighted.

Modify `Gitlab::Highlight` to support `since` param which will
then be used to determine the starting line number.
</pre>
</div>
</content>
</entry>
<entry>
<title>Speed up loading and filtering deploy keys and their projects</title>
<updated>2019-08-05T13:42:34+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2019-08-01T16:18:17+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d3a3db4218e10c65c2e87c763ad02169f3736883'/>
<id>d3a3db4218e10c65c2e87c763ad02169f3736883</id>
<content type='text'>
This commit changes how we eager-load projects, routes, and namespaces
required by the deploy keys endpoint, getting a 10x improvement in my
local testing.

The endpoint still doesn't scale in-general, but going from ~13 seconds
to dump a 63K result to generating the same thing in ~1.6 seconds seems
like a good improvement to me.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit changes how we eager-load projects, routes, and namespaces
required by the deploy keys endpoint, getting a 10x improvement in my
local testing.

The endpoint still doesn't scale in-general, but going from ~13 seconds
to dump a 63K result to generating the same thing in ~1.6 seconds seems
like a good improvement to me.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '57953-fix-unfolded-diff-suggestions' into 'master'</title>
<updated>2019-07-23T14:13:39+00:00</updated>
<author>
<name>Kamil Trzciński</name>
<email>ayufan@ayufan.eu</email>
</author>
<published>2019-07-23T14:13:39+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=aed076353d8a8867c9ef2d61a6fda123d07fad77'/>
<id>aed076353d8a8867c9ef2d61a6fda123d07fad77</id>
<content type='text'>
Fix suggestion on lines that are not part of an MR

See merge request gitlab-org/gitlab-ce!30606</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix suggestion on lines that are not part of an MR

See merge request gitlab-org/gitlab-ce!30606</pre>
</div>
</content>
</entry>
<entry>
<title>Fix suggestion on lines that are not part of an MR</title>
<updated>2019-07-22T05:25:24+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-07-22T05:25:24+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=866bef8059591db9a17db71d66a1321b0ca25153'/>
<id>866bef8059591db9a17db71d66a1321b0ca25153</id>
<content type='text'>
Return the `text` as plain string in the response instead of
including HTML tags but keep `rich_text` as is.

The fix is to modify `Blob::UnfoldPresenter#diff_files` to map
each raw diff line (limited by the range specified) to a
corresponding line in an array of highlighted lines to use as
`rich_text`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Return the `text` as plain string in the response instead of
including HTML tags but keep `rich_text` as is.

The fix is to modify `Blob::UnfoldPresenter#diff_files` to map
each raw diff line (limited by the range specified) to a
corresponding line in an array of highlighted lines to use as
`rich_text`.
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor: model errors for multi cluster validation</title>
<updated>2019-07-11T07:22:58+00:00</updated>
<author>
<name>Dylan Griffith</name>
<email>dyl.griffith@gmail.com</email>
</author>
<published>2019-07-10T05:33:09+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=dacd0ee18b617f0c81c4a478a4d801b3c37e0c56'/>
<id>dacd0ee18b617f0c81c4a478a4d801b3c37e0c56</id>
<content type='text'>
The current approach requires catching exceptions to handle these errors
and callers are already handling model validations so it seems more
appropriate.  Also it seemed to convoluted to add this logic directly to
the model since the model needs to check too many possible associations
to determine whether or not there are more than one cluster since the
model doesn't know what it's being created on. Additionally we only
wanted to validate during create to avoid the risk of existing models
becoming invalid by many different edge cases.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The current approach requires catching exceptions to handle these errors
and callers are already handling model validations so it seems more
appropriate.  Also it seemed to convoluted to add this logic directly to
the model since the model needs to check too many possible associations
to determine whether or not there are more than one cluster since the
model doesn't know what it's being created on. Additionally we only
wanted to validate during create to avoid the risk of existing models
becoming invalid by many different edge cases.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'graphql-tree-last-commit' into 'master'</title>
<updated>2019-06-28T10:02:57+00:00</updated>
<author>
<name>Lin Jen-Shin</name>
<email>godfat@godfat.org</email>
</author>
<published>2019-06-28T10:02:57+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2321b337f1487031e2cab8e1a4e778f3aaf8e2da'/>
<id>2321b337f1487031e2cab8e1a4e778f3aaf8e2da</id>
<content type='text'>
Added commit type to tree GraphQL type

See merge request gitlab-org/gitlab-ce!29412</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Added commit type to tree GraphQL type

See merge request gitlab-org/gitlab-ce!29412</pre>
</div>
</content>
</entry>
</feed>
