<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git/app/views/devise/shared, branch docs-pages-https</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fix Shows signin tab after new user email confirmation</title>
<updated>2018-01-18T13:32:44+00:00</updated>
<author>
<name>Jacopo</name>
<email>beschi.jacopo@gmail.com</email>
</author>
<published>2018-01-01T22:43:16+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=269594bf2277e14d8cd189cdbbeeee7db8ed23d7'/>
<id>269594bf2277e14d8cd189cdbbeeee7db8ed23d7</id>
<content type='text'>
When a new user confirm his email the signin tab is correctly shown.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When a new user confirm his email the signin tab is correctly shown.
</pre>
</div>
</content>
</entry>
<entry>
<title>remove ambiguity about which resource type to be using for new sessions</title>
<updated>2017-12-05T09:01:46+00:00</updated>
<author>
<name>Brett Walker</name>
<email>brett@digitalmoksha.com</email>
</author>
<published>2017-12-05T09:01:46+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=b0e2e21b7db5cc80f6a17b19354e91dd7fcf6c8c'/>
<id>b0e2e21b7db5cc80f6a17b19354e91dd7fcf6c8c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Allow password authentication to be disabled entirely</title>
<updated>2017-11-23T13:16:14+00:00</updated>
<author>
<name>Markus Koller</name>
<email>markus-koller@gmx.ch</email>
</author>
<published>2017-11-23T13:16:14+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=257fd5713485a05460a9170190100643199a7e48'/>
<id>257fd5713485a05460a9170190100643199a7e48</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add missing classes to omniauth remember-me checkbox and add correct font-size</title>
<updated>2017-09-14T17:58:15+00:00</updated>
<author>
<name>Jedidiah</name>
<email>hello@jedidiah.eu</email>
</author>
<published>2017-09-14T17:58:15+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3140006355e35663ca0f4f6e2b4a2157d39480cd'/>
<id>3140006355e35663ca0f4f6e2b4a2157d39480cd</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>add padding above Remember Me for social login</title>
<updated>2017-07-20T05:02:16+00:00</updated>
<author>
<name>Simon Knox</name>
<email>psimyn@gmail.com</email>
</author>
<published>2017-07-18T13:45:11+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a4c6a03b935fd09098f7da821d9a1c0a30b88859'/>
<id>a4c6a03b935fd09098f7da821d9a1c0a30b88859</id>
<content type='text'>
also fix case
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
also fix case
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixes needed when GitLab sign-in is not enabled</title>
<updated>2017-07-13T14:08:27+00:00</updated>
<author>
<name>Robin Bobbitt</name>
<email>ryehle@us.ibm.com</email>
</author>
<published>2017-06-27T18:02:09+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=672a68d3724bcae676d18244c85566e7d664a169'/>
<id>672a68d3724bcae676d18244c85566e7d664a169</id>
<content type='text'>
When sign-in is disabled:
 - skip password expiration checks
 - prevent password reset requests
 - don’t show Password tab in User Settings
 - don’t allow login with username/password for Git over HTTP requests
 - render 404 on requests to Profiles::PasswordsController
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When sign-in is disabled:
 - skip password expiration checks
 - prevent password reset requests
 - don’t show Password tab in User Settings
 - don’t allow login with username/password for Git over HTTP requests
 - render 404 on requests to Profiles::PasswordsController
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '18000-remember-me-for-oauth-login' into 'master'</title>
<updated>2017-07-06T12:59:21+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2017-07-06T12:59:21+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=a33fb2132cc9c1924fe986ce562cd7bea084a5c9'/>
<id>a33fb2132cc9c1924fe986ce562cd7bea084a5c9</id>
<content type='text'>
Fix `migration:path` build for "Honor the 'Remember me' parameter for OAuth-based login"

Closes #34713

See merge request !12668</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix `migration:path` build for "Honor the 'Remember me' parameter for OAuth-based login"

Closes #34713

See merge request !12668</pre>
</div>
</content>
</entry>
<entry>
<title>Implement review comments for !11963 from @adamniedzielski.</title>
<updated>2017-07-06T06:30:07+00:00</updated>
<author>
<name>Timothy Andrew</name>
<email>mail@timothyandrew.net</email>
</author>
<published>2017-06-30T16:36:36+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=8fa08ea3cd81e906c4f4951c70e3571defeab7c7'/>
<id>8fa08ea3cd81e906c4f4951c70e3571defeab7c7</id>
<content type='text'>
- Change double quotes to single quotes.
- Why is `OmniAuth.config.full_host` being reassigned in the integration test?
- Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task
- Other minor changes
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Change double quotes to single quotes.
- Why is `OmniAuth.config.full_host` being reassigned in the integration test?
- Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task
- Other minor changes
</pre>
</div>
</content>
</entry>
<entry>
<title>Move OAuth "remember me" javascript logic into a class.</title>
<updated>2017-07-06T06:30:05+00:00</updated>
<author>
<name>Timothy Andrew</name>
<email>mail@timothyandrew.net</email>
</author>
<published>2017-06-15T12:13:30+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d705a2548ceebe0fc63356e3e5b0afc54a109d9f'/>
<id>d705a2548ceebe0fc63356e3e5b0afc54a109d9f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add integration tests around OAuth login.</title>
<updated>2017-07-06T06:30:05+00:00</updated>
<author>
<name>Timothy Andrew</name>
<email>mail@timothyandrew.net</email>
</author>
<published>2017-06-14T04:30:07+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/gitlab/gitlab-ce.git/commit/?id=e936db963e2adb549533cfedcac6f342d7e5e32e'/>
<id>e936db963e2adb549533cfedcac6f342d7e5e32e</id>
<content type='text'>
- There was previously a test for `saml` login in `login_spec`, but this didn't
  seem to be passing. A lot of things didn't seem right here, and I suspect that
  this test hasn't been running. I'll investigate this further.

- It took almost a whole working day to figure out this line:

    OmniAuth.config.full_host = -&gt;(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') }

  As always, it's obvious in retrospect, but it took some digging to figure out
  tests were failing and returning 404s during the callback phase.

- Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- There was previously a test for `saml` login in `login_spec`, but this didn't
  seem to be passing. A lot of things didn't seem right here, and I suspect that
  this test hasn't been running. I'll investigate this further.

- It took almost a whole working day to figure out this line:

    OmniAuth.config.full_host = -&gt;(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') }

  As always, it's obvious in retrospect, but it took some digging to figure out
  tests were failing and returning 404s during the callback phase.

- Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
</pre>
</div>
</content>
</entry>
</feed>
